update xercesImpl to 2.12.1 (from 2.12.0)#641
Closed
sseide wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
|
I wonder, if it would be better to use the sha512 sum in this case, as the uploaders pgp key can't be found anywhere. |
Collaborator
|
AFAIK Xerces is ASF project, so the key should be located at http://xerces.apache.org/ somewhere |
Collaborator
|
Ah, the library was published by @apupier somehow manually (see https://issues.apache.org/jira/browse/XERCESJ-1724) On the other hand, the file at Central is the same as the one in the official release: So I agree we should use SHA512, and we should use SHA512 for all other xerces jars. |
Contributor
|
Thanks for the PR. A version using the SHA512 checksums has been committed to trunk. It would be great, if you could test next build from trunk or nightly. |
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
Based on patch by Stefan Seide (stefan at trilobyte-se.de) Closes apache#641
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
within the current xercesImpl version 2.12.0 a vulnerabilities was found. It is fixed with the update to 2.12.1.
Motivation and Context
Fix potential security problems
How Has This Been Tested?
run gradlew check, first run failed with one library (xstream) having changed as expected, rerun with "-PupdateExpectedJars" switch and "-PchecksumUpdate".
The following executions of gradlew check and gradlew test succeeded now.
The update of the checksum was needed because the signer of the xercesImpl release has changed and a new gpg key was used to sign the maven release? (see https://issues.apache.org/jira/browse/XERCESJ-1724)
Screenshots (if appropriate):
none
Types of changes
Checklist: