Encode the personal part of email addresses in SMTP Sampler #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSchumacher
force-pushed
the
bug65149-encode-email-addresses
branch
from
7e80827
to
3f2d9ec
Compare
Often those personal parts contain umlauts. Try to find these and let MimeUtility encode those as quoted encodings. Bugzilla Id: 65149
FSchumacher
force-pushed
the
bug65149-encode-email-addresses
branch
from
3f2d9ec
to
fd8efc5
Compare
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
============================================
- Coverage 55.46% 55.44% -0.02%
+ Complexity 10181 10179 -2
============================================
Files 1046 1046
Lines 64147 64157 +10
Branches 7265 7267 +2
============================================
- Hits 35580 35573 -7
- Misses 26060 26080 +20
+ Partials 2507 2504 -3
Continue to review full report at Codecov.
|
asfgit
pushed a commit
that referenced
this pull request
Mar 8, 2021
That Exception can't be thrown in that private method. Part of new code, that was introduced to encode the personal part of email addresses in SMTP Sampler Bugzilla Id: 65149 Relates to #644 on github
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
Often those personal parts contain umlauts. Try to find these and let MimeUtility encode those as quoted encodings. Bugzilla Id: 65149 Closes apache#644 on github
kkalinin
pushed a commit
to kkalinin/jmeter
that referenced
this pull request
Mar 11, 2021
That Exception can't be thrown in that private method. Part of new code, that was introduced to encode the personal part of email addresses in SMTP Sampler Bugzilla Id: 65149 Relates to apache#644 on github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Often those personal parts contain umlauts. Try to find these
and let
MimeUtilityencode those as quoted encodings.Motivation and Context
Bugzilla Id: 65149
How Has This Been Tested?
Used a simple test plan and a dummy smtp server.
Screenshots (if appropriate):
Types of changes
Checklist: