Skip to content

Some Cmd scripts don't work with spaces in JMeter path#664

Closed
tilln wants to merge 2 commits intoapache:masterfrom
tilln:fix/whitespace-in-windows-path
Closed

Some Cmd scripts don't work with spaces in JMeter path#664
tilln wants to merge 2 commits intoapache:masterfrom
tilln:fix/whitespace-in-windows-path

Conversation

@tilln
Copy link
Contributor

@tilln tilln commented Apr 22, 2021

Description

Some of the Windows *.cmd scripts do not work if the JMETER_HOME location (i.e. folder where JMeter is installed) contains spaces (or other characters that need to be escaped).

Motivation and Context

Scripts would fail to run with the below error.
Error: Could not find or load main class [...]\bin\ApacheJMeter.jar
Work-around is to install JMeter at path without spaces however this may not always be in the user's control.

How Has This Been Tested?

Tested locally.
No unit test added due to the (trivial) nature of the issue and fix.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@6caf328). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #664   +/-   ##
=========================================
  Coverage          ?   55.34%           
  Complexity        ?    10189           
=========================================
  Files             ?     1046           
  Lines             ?    64435           
  Branches          ?     7308           
=========================================
  Hits              ?    35660           
  Misses            ?    26266           
  Partials          ?     2509           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6caf328...88b622c. Read the comment docs.

@asfgit asfgit closed this in 08c3c59 Apr 25, 2021
@FSchumacher
Copy link
Contributor

Thanks for the patch.

@vlsi
Copy link
Collaborator

vlsi commented Apr 25, 2021

@tilln , thank you for the fix. Would you please add a test case for it?
For instance, what if GitHub CI always clones JMeter to a folder with space and double quote?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments