Some Cmd scripts don't work with spaces in JMeter path#664
Closed
tilln wants to merge 2 commits intoapache:masterfrom
Closed
Some Cmd scripts don't work with spaces in JMeter path#664tilln wants to merge 2 commits intoapache:masterfrom
tilln wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=========================================
Coverage ? 55.34%
Complexity ? 10189
=========================================
Files ? 1046
Lines ? 64435
Branches ? 7308
=========================================
Hits ? 35660
Misses ? 26266
Partials ? 2509 Continue to review full report at Codecov.
|
FSchumacher
reviewed
Apr 24, 2021
Contributor
|
Thanks for the patch. |
Collaborator
|
@tilln , thank you for the fix. Would you please add a test case for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some of the Windows *.cmd scripts do not work if the JMETER_HOME location (i.e. folder where JMeter is installed) contains spaces (or other characters that need to be escaped).
Motivation and Context
Scripts would fail to run with the below error.
Error: Could not find or load main class [...]\bin\ApacheJMeter.jarWork-around is to install JMeter at path without spaces however this may not always be in the user's control.
How Has This Been Tested?
Tested locally.
No unit test added due to the (trivial) nature of the issue and fix.
Screenshots (if appropriate):
Types of changes
Checklist: