Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split function test refactor with failure and different success scena… #690

Conversation

SampathKumarAmex
Copy link
Contributor

Description

Split function unit test refactor with failure and different success scenarios.

Motivation and Context

  1. I have separated the test scenarios into three.
  • Failure scenario
  • Success scenario without passing any parameters
  • Success scenario with previous result value only

Actually, it's good to further separate all the different variations in scenario #2. So that we will have feedback from all the tests in single execution (i.e. CI build) even when one of the test scenarios fail. Also, it improves the readability and help to understand the scenarios better. Having said that, I haven't done that as part of this PR.

  1. Used the JUnit 5 assertions as the test is already using JUnit 5 @Test annotation. This is to make the JUnit 5 usage consistent in this test class

How Has This Been Tested?

n/a - Unit test refactoring

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

Codecov Report

Merging #690 (1f0f2d5) into master (37be72f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #690   +/-   ##
=========================================
  Coverage     55.59%   55.59%           
- Complexity    10335    10336    +1     
=========================================
  Files          1059     1059           
  Lines         65045    65045           
  Branches       7399     7399           
=========================================
+ Hits          36159    36161    +2     
+ Misses        26337    26336    -1     
+ Partials       2549     2548    -1     
Impacted Files Coverage Δ
...a/org/apache/jmeter/timers/PoissonRandomTimer.java 78.37% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37be72f...1f0f2d5. Read the comment docs.

@asfgit asfgit closed this in af7fc4d Jan 8, 2022
@FSchumacher
Copy link
Contributor

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants