Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write graphite guide in realtime section #699

Closed
wants to merge 1 commit into from
Closed

Write graphite guide in realtime section #699

wants to merge 1 commit into from

Conversation

shblue21
Copy link
Contributor

Description

Write graphite setting guide docuementation in realtime section, with simple pickle protocol

Motivation and Context

Improved accessibility for Jmeter and Graphite integration

How Has This Been Tested?

After building with gradle site, check the screen by resolution.

Screenshots (if appropriate):

image

Types of changes

  • Write docs

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Copy link
Contributor

@pmouawad pmouawad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR.
Can you fix the typos so that I can merge it ?
Regards

write graphite setting, in realtime section,
with simple pickle protocol
@shblue21
Copy link
Contributor Author

shblue21 commented Feb 21, 2022

Thanks for the feedback. As reviewed, the text in the docs has been revised.
It's a small help, but I'm happy to be able to contribute.

@asfgit asfgit closed this in 4ea72b5 Mar 5, 2022
@FSchumacher
Copy link
Contributor

Thanks for the PR. I rephrased the wording a bit and removed space at the end of line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants