Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to make rendering of large text results faster #706

Closed

Conversation

FSchumacher
Copy link
Contributor

Description

Currently the used JEditorPane is slow when using large texts, as it
tries to find good places to break words.

This hack disables word wrapping by using non-wrapping views
for every element in the JEditorPane.

How Has This Been Tested?

Sampled a biggish http site and looked at the result in the view results tree. Especially switching between a small and a large text result, would take a few seconds and make the UI unresponsive.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Currently the used JEditorPane is slow when using large texts, as it
tries to find good places to break words.

This hack disables word wrapping by using non-wrapping views
for every element in the JEditorPane.
@codecov-commenter
Copy link

Codecov Report

Merging #706 (c7e912c) into master (c2f29cc) will decrease coverage by 0.31%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
- Coverage     55.54%   55.23%   -0.32%     
- Complexity    10350    10377      +27     
============================================
  Files          1061     1061              
  Lines         65220    65706     +486     
  Branches       7433     7531      +98     
============================================
+ Hits          36229    36291      +62     
- Misses        26432    26815     +383     
- Partials       2559     2600      +41     
Impacted Files Coverage Δ
...rg/apache/jmeter/visualizers/SamplerResultTab.java 30.64% <0.00%> (-1.72%) ⬇️
...ava/org/apache/jmeter/functions/RegexFunction.java 59.00% <0.00%> (-30.69%) ⬇️
...meter/engine/util/ReplaceFunctionsWithStrings.java 52.08% <0.00%> (-30.06%) ⬇️
.../jmeter/protocol/http/parser/RegexpHTMLParser.java 43.75% <0.00%> (-29.78%) ⬇️
...va/org/apache/jmeter/extractor/RegexExtractor.java 57.68% <0.00%> (-28.93%) ⬇️
.../jmeter/protocol/http/parser/HtmlParsingUtils.java 49.19% <0.00%> (-11.65%) ⬇️
...jmeter/protocol/http/util/accesslog/LogFilter.java 70.67% <0.00%> (-10.64%) ⬇️
...r/protocol/http/modifier/URLRewritingModifier.java 69.72% <0.00%> (-8.69%) ⬇️
...jmeter/protocol/http/control/HttpMirrorThread.java 74.69% <0.00%> (-8.18%) ⬇️
...meter/protocol/http/config/MultipartUrlConfig.java 68.91% <0.00%> (-7.65%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f29cc...c7e912c. Read the comment docs.

…results tree

This setting is used to decide, whether the text view should switch to a simpler
view model. That can help to get rid of UI unresponsiveness on large contents.
@asfgit asfgit closed this in 40de048 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants