Enable darklaf on rsyntaxtextarea again #719
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id of the theme has been changed to all lowercase
vlsi
reviewed
Jul 5, 2022
| @@ -200,7 +200,7 @@ public LookAndFeelCommand() { | |||
| } | |||
|
|
|||
| public static boolean isDarklafTheme() { | |||
| return "Darklaf".equals(UIManager.getLookAndFeel().getID()); // $NON-NLS-1$ | |||
| return "Darklaf".equalsIgnoreCase(UIManager.getLookAndFeel().getID()); // $NON-NLS-1$ | |||
There was a problem hiding this comment.
Wow. This is unexpected for me. I wonder if we could eliminate isDarklafTheme() altogether. It is really surprising that isDarklafTheme() impacts colors.
There was a problem hiding this comment.
If you know how, it would be great, but I think it comes from JSyntaxTextArea not handling the dark LaF well enough, so that darklaf has some special handling for it. Sadly, that has to be done by hand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SyntaxTextAreas look bad on dark mode with Darklaf, as
the id of the theme has been changed to all lowercase and we didn't recognize it anymore.
Bugzilla Id: 66157
How Has This Been Tested?
Opened a test plan in dark mode with a JSR223 Sampler
Screenshots (if appropriate):
Types of changes
Checklist: