diff --git a/clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java b/clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java index 55f416a2fa04..8ef8129d795d 100644 --- a/clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java +++ b/clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java @@ -473,13 +473,12 @@ synchronized public DescribeConfigsResult describeConfigs(Collection map = - brokerConfigs.get(Integer.valueOf(resource.name())); - if (map == null) { + int brokerId = Integer.valueOf(resource.name()); + if (brokerId >= brokerConfigs.size()) { throw new InvalidRequestException("Broker " + resource.name() + " not found."); } - return toConfigObject(map); + return toConfigObject(brokerConfigs.get(brokerId)); } case TOPIC: { TopicMetadata topicMetadata = allTopics.get(resource.name()); @@ -538,11 +537,10 @@ synchronized private Throwable handleIncrementalResourceAlteration( } catch (NumberFormatException e) { return e; } - Map map = brokerConfigs.get(brokerId); - if (map == null) { + if (brokerId >= brokerConfigs.size()) { return new InvalidRequestException("no such broker as " + brokerId); } - HashMap newMap = new HashMap<>(map); + HashMap newMap = new HashMap<>(brokerConfigs.get(brokerId)); for (AlterConfigOp op : ops) { switch (op.opType()) { case SET: