MINOR: Replacing for with foreach loop in stream test classes

Author: Prabhat Kashyap <prabhat.kashyap@knoldus.in> Reviewers: Ismael Juma, Damian Guy, Guozhang Wang Closes #2305 from PKOfficial/code-refactor
apache · Jan 10, 2017 · 75469a3 · 75469a3
1 parent fe82330
commit 75469a3
Show file tree

Hide file tree

Showing 17 changed files with 227 additions and 226 deletions.
diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamBranchTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamBranchTest.java
@@ -87,8 +87,8 @@ public boolean test(Integer key, String value) {
         }
 
         driver = new KStreamTestDriver(builder);
-        for (int i = 0; i < expectedKeys.length; i++) {
+        for (int expectedKey : expectedKeys) {
-            driver.process(topicName, expectedKeys[i], "V" + expectedKeys[i]);
+            driver.process(topicName, expectedKey, "V" + expectedKey);
         }
 
         assertEquals(3, processors[0].processed.size());

diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFilterTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFilterTest.java
@@ -63,8 +63,8 @@ public void testFilter() {
         stream.filter(isMultipleOfThree).process(processor);
 
         driver = new KStreamTestDriver(builder);
-        for (int i = 0; i < expectedKeys.length; i++) {
+        for (int expectedKey : expectedKeys) {
-            driver.process(topicName, expectedKeys[i], "V" + expectedKeys[i]);
+            driver.process(topicName, expectedKey, "V" + expectedKey);
         }
 
         assertEquals(2, processor.processed.size());
@@ -83,8 +83,8 @@ public void testFilterNot() {
         stream.filterNot(isMultipleOfThree).process(processor);
 
         driver = new KStreamTestDriver(builder);
-        for (int i = 0; i < expectedKeys.length; i++) {
+        for (int expectedKey : expectedKeys) {
-            driver.process(topicName, expectedKeys[i], "V" + expectedKeys[i]);
+            driver.process(topicName, expectedKey, "V" + expectedKey);
         }
 
         assertEquals(5, processor.processed.size());

diff --git a/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java b/streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java
@@ -71,8 +71,8 @@ public Iterable<KeyValue<String, String>> apply(Integer key, String value) {
         stream.flatMap(mapper).process(processor);
 
         driver = new KStreamTestDriver(builder);
-        for (int i = 0; i < expectedKeys.length; i++) {
+        for (int expectedKey : expectedKeys) {
-            driver.process(topicName, expectedKeys[i], "V" + expectedKeys[i]);
+            driver.process(topicName, expectedKey, "V" + expectedKey);
         }
 
         assertEquals(6, processor.processed.size());

diff --git a/...ms/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapValuesTest.java b/...ms/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapValuesTest.java
@@ -70,8 +70,8 @@ public Iterable<String> apply(String value) {
         stream.flatMapValues(mapper).process(processor);
 
         driver = new KStreamTestDriver(builder);
-        for (int i = 0; i < expectedKeys.length; i++) {
+        for (int expectedKey : expectedKeys) {
-            driver.process(topicName, expectedKeys[i], "V" + expectedKeys[i]);
+            driver.process(topicName, expectedKey, "V" + expectedKey);
         }
 
         assertEquals(8, processor.processed.size());