Skip to content

MINOR: expose number of forwarding requests to metrics #10086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MINOR: expose number of forwarding requests to metrics #10086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ package kafka.server

import java.util.concurrent.LinkedBlockingDeque
import java.util.concurrent.atomic.AtomicReference

import kafka.common.{InterBrokerSendThread, RequestAndCompletionHandler}
import kafka.utils.Logging
import kafka.metrics.KafkaMetricsGroup
import org.apache.kafka.clients._
import org.apache.kafka.common.Node
import org.apache.kafka.common.metrics.Metrics
Expand Down Expand Up @@ -120,7 +119,8 @@ class BrokerToControllerChannelManagerImpl(
channelName: String,
threadNamePrefix: Option[String],
retryTimeoutMs: Long
) extends BrokerToControllerChannelManager with Logging {
) extends BrokerToControllerChannelManager with KafkaMetricsGroup {
private val responseQueueSizeMetricName = "NumRequestsForwardingToController"
private val logContext = new LogContext(s"[broker-${config.brokerId}-to-controller] ")
private val manualMetadataUpdater = new ManualMetadataUpdater()
private val apiVersions = new ApiVersions()
Expand All @@ -129,9 +129,11 @@ class BrokerToControllerChannelManagerImpl(

def start(): Unit = {
requestThread.start()
newGauge(responseQueueSizeMetricName, () => requestThread.queueSize)
}

def shutdown(): Unit = {
removeMetric(responseQueueSizeMetricName)
requestThread.shutdown()
info(s"Broker to controller channel manager for $channelName shutdown")
}
Expand Down