KAFKA-12323 Follow-up: Refactor the unit test a bit #10205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
reviewed
Feb 24, 2021
There was a problem hiding this comment.
Build failed with checkstyle error:
[2021-02-24T20ː57ː02.060Z] > Task ːstreamsːcheckstyleTest FAILED
[2021-02-24T20ː57ː02.060Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10205/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.javaː1854ː14: Unnecessary parentheses around string "K". [UnnecessaryParentheses]
[2021-02-24T20ː57ː02.060Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10205/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.javaː1855ː14: Unnecessary parentheses around string "V". [UnnecessaryParentheses]
[2021-02-24T20ː57ː02.060Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10205/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.javaː1856ː14: Unnecessary parentheses around string "K". [UnnecessaryParentheses]
[2021-02-24T20ː57ː02.060Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10205/streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.javaː1857ː14: Unnecessary parentheses around string "V". [UnnecessaryParentheses]
| @@ -1844,19 +1844,17 @@ public void process(final Object key, final Object value) {} | |||
| assertEquals(0, punctuatedWallClockTime.size()); | |||
|
|
|||
| mockTime.sleep(100L); | |||
| for (long i = 0L; i < 10L; i++) { | |||
There was a problem hiding this comment.
Since we do not need it really: a single record is sufficient to trigger the punctuation.
| @@ -1936,7 +1934,7 @@ public void process(final Object key, final Object value) { | |||
| clientSupplier.consumer.addRecord(new ConsumerRecord<>( | |||
| topic1, | |||
| 1, | |||
| 0L, | |||
| 100L, | |||
There was a problem hiding this comment.
nit: can we pick a different value to disambiguate (wall-clock time is set to 100L above)?
|
@mjsax updated. |
mjsax
approved these changes
Feb 25, 2021
| 0L, | ||
| 100L, | ||
| 110L, | ||
| 110L, |
guozhangwang
added a commit
that referenced
this pull request
Mar 1, 2021
Reviewers: Matthias J. Sax <matthias@confluent.io>
guozhangwang
added a commit
that referenced
this pull request
Mar 1, 2021
Reviewers: Matthias J. Sax <matthias@confluent.io>
|
Cherry-picked to 2.8 and 2.7, cc RM @vvcephei |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Mar 2, 2021
* apache-github/trunk: (37 commits) KAFKA-10357: Extract setup of changelog from Streams partition assignor (apache#10163) KAFKA-10251: increase timeout for consuming records (apache#10228) KAFKA-12394; Return `TOPIC_AUTHORIZATION_FAILED` in delete topic response if no describe permission (apache#10223) MINOR: Disable transactional/idempotent system tests for Raft quorums (apache#10224) KAFKA-10766: Unit test cases for RocksDBRangeIterator (apache#9717) KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore (apache#10052) KAFKA-12268: Implement task idling semantics via currentLag API (apache#10137) MINOR: Time and log producer state recovery phases (apache#10241) MINOR: correct the error message of validating uint32 (apache#10193) MINOR: Format the revoking active log output in `StreamsPartitionAssignor` (apache#10242) KAFKA-12323 Follow-up: Refactor the unit test a bit (apache#10205) MINOR: Remove stack trace of the lock exception in a debug log4j (apache#10231) MINOR: Word count should account for extra whitespaces between words (apache#10229) MINOR; Small refactor in `GroupMetadata` (apache#10236) KAFKA-10340: Proactively close producer when cancelling source tasks (apache#10016) KAFKA-12329; kafka-reassign-partitions command should give a better error message when a topic does not exist (apache#10141) KAFKA-12254: Ensure MM2 creates topics with source topic configs (apache#10217) MINOR: fix kafka-metadata-shell.sh (apache#10226) KAFKA-12374: Add missing config sasl.mechanism.controller.protocol (apache#10199) KAFKA-10101: Fix edge cases in Log.recoverLog and LogManager.loadLogs (apache#8812) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)