KAFKA-9295: increase heartbeat and session timeout #10715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ableegoldman , as discussed, could you help review this PR to increase session timeout? Thanks. |
|
failed test is flaky RaftClusterTest: |
|
@showuon I don't think we need to increase the heartbeat interval, let's just bump up the session timeout for now. We still want to be relatively quick in our broker requests/responses |
|
@ableegoldman , no problem! Updated! Thanks. |
ableegoldman
approved these changes
May 19, 2021
|
I'll monitor it and let you know when completed. :) |
|
@ableegoldman , Failed test is unrelated and flaky. Thanks. |
|
Merged to trunk at exactly 11pm PST (May 18th 2021) -- be on the lookout for any failures on builds kicked off after this time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase heartbeat and session timeout to make the test reliable.
session timeout -> 20 sec
heartbeat timeout -> 20/3 = 7 sec
Committer Checklist (excluded from commit message)