Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade compression libraries (Q3 2021) #11303

Merged
merged 1 commit into from Sep 7, 2021
Merged

Conversation

ijuma
Copy link
Contributor

@ijuma ijuma commented Sep 7, 2021

lz4-java: 1.7.1 -> 1.8.0

The most noteworthy change is the upgrade of the
underlying C library to 1.9.3. Details:

snappy-java: 1.1.8.1 -> 1.1.8.4

The most noteworthy change is support for Apple M1.
Details:

zstd-jni: 1.5.0-2 -> 1.5.0-4

Minor fixes, details:

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested a review from chia7712 September 7, 2021 04:03
Copy link
Contributor

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw there's a build error:

 * What went wrong:
[2021-09-07T04ː12ː35.647Z] Execution failed for task 'ːstreamsːstreams-scala:compileScala'.
[2021-09-07T04ː12ː35.647Z] > Timeout waiting to lock zinc-1.3.5_2.12.14_8 compiler cache (/home/jenkins/.gradle/caches/7.2/zinc-1.3.5_2.12.14_8). It is currently in use by another Gradle instance.
[2021-09-07T04ː12ː35.647Z]   Owner PID: 4138
[2021-09-07T04ː12ː35.647Z]   Our PID: 4217
[2021-09-07T04ː12ː35.647Z]   Owner Operation: 
[2021-09-07T04ː12ː35.647Z]   Our operation: 
[2021-09-07T04ː12ː35.647Z]   Lock file: /home/jenkins/.gradle/caches/7.2/zinc-1.3.5_2.12.14_8/zinc-1.3.5_2.12.14_8.lock

Not sure if this is related to this change or just a gradle bug?
Otherwise. LGTM. Thanks.

@jlprat
Copy link
Contributor

jlprat commented Sep 7, 2021

I had the same error on another PR yesterday. Might be a Gradle build instance turned into a zombie on a Jenkins worker.

I saw there's a build error:

 * What went wrong:
[2021-09-07T04ː12ː35.647Z] Execution failed for task 'ːstreamsːstreams-scala:compileScala'.
[2021-09-07T04ː12ː35.647Z] > Timeout waiting to lock zinc-1.3.5_2.12.14_8 compiler cache (/home/jenkins/.gradle/caches/7.2/zinc-1.3.5_2.12.14_8). It is currently in use by another Gradle instance.
[2021-09-07T04ː12ː35.647Z]   Owner PID: 4138
[2021-09-07T04ː12ː35.647Z]   Our PID: 4217
[2021-09-07T04ː12ː35.647Z]   Owner Operation: 
[2021-09-07T04ː12ː35.647Z]   Our operation: 
[2021-09-07T04ː12ː35.647Z]   Lock file: /home/jenkins/.gradle/caches/7.2/zinc-1.3.5_2.12.14_8/zinc-1.3.5_2.12.14_8.lock

Not sure if this is related to this change or just a gradle bug?
Otherwise. LGTM. Thanks.

Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma ijuma merged commit 49f7c82 into trunk Sep 7, 2021
@ijuma ijuma deleted the compression-upgrade-3.1 branch September 7, 2021 15:46
xdgrulez pushed a commit to xdgrulez/kafka that referenced this pull request Dec 22, 2021
lz4-java: 1.7.1 -> 1.8.0

The most noteworthy change is the upgrade of the
underlying C library to 1.9.3. Details:

* https://github.com/lz4/lz4-java/releases/tag/1.8.0
* https://github.com/lz4/lz4/releases/tag/v1.9.3

snappy-java: 1.1.8.1 -> 1.1.8.4

The most noteworthy change is support for Apple M1.
Details:

* https://github.com/xerial/snappy-java/releases/tag/1.1.8.2 
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.3
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.4

zstd-jni: 1.5.0-2 -> 1.5.0-4

Minor fixes, details:

* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-3
* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-4

Reviewers: David Jacot <djacot@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, Luke Chen <showuon@gmail.com>, Josep Prat <josep.prat@aiven.io>
hshi2022 pushed a commit to hshi2022/kafka that referenced this pull request Jun 8, 2022
lz4-java: 1.7.1 -> 1.8.0

The most noteworthy change is the upgrade of the
underlying C library to 1.9.3. Details:

* https://github.com/lz4/lz4-java/releases/tag/1.8.0
* https://github.com/lz4/lz4/releases/tag/v1.9.3

snappy-java: 1.1.8.1 -> 1.1.8.4

The most noteworthy change is support for Apple M1.
Details:

* https://github.com/xerial/snappy-java/releases/tag/1.1.8.2 
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.3
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.4

zstd-jni: 1.5.0-2 -> 1.5.0-4

Minor fixes, details:

* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-3
* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-4

Reviewers: David Jacot <djacot@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, Luke Chen <showuon@gmail.com>, Josep Prat <josep.prat@aiven.io>
hshi2022 pushed a commit to hshi2022/kafka that referenced this pull request Jun 9, 2022
lz4-java: 1.7.1 -> 1.8.0

The most noteworthy change is the upgrade of the
underlying C library to 1.9.3. Details:

* https://github.com/lz4/lz4-java/releases/tag/1.8.0
* https://github.com/lz4/lz4/releases/tag/v1.9.3

snappy-java: 1.1.8.1 -> 1.1.8.4

The most noteworthy change is support for Apple M1.
Details:

* https://github.com/xerial/snappy-java/releases/tag/1.1.8.2 
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.3
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.4

zstd-jni: 1.5.0-2 -> 1.5.0-4

Minor fixes, details:

* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-3
* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-4

Reviewers: David Jacot <djacot@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, Luke Chen <showuon@gmail.com>, Josep Prat <josep.prat@aiven.io>
hshi2022 added a commit to linkedin/kafka that referenced this pull request Jun 9, 2022
…354)

lz4-java: 1.7.1 -> 1.8.0

The most noteworthy change is the upgrade of the
underlying C library to 1.9.3. Details:

* https://github.com/lz4/lz4-java/releases/tag/1.8.0
* https://github.com/lz4/lz4/releases/tag/v1.9.3

snappy-java: 1.1.8.1 -> 1.1.8.4

The most noteworthy change is support for Apple M1.
Details:

* https://github.com/xerial/snappy-java/releases/tag/1.1.8.2 
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.3
* https://github.com/xerial/snappy-java/releases/tag/1.1.8.4

zstd-jni: 1.5.0-2 -> 1.5.0-4

Minor fixes, details:

* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-3
* https://github.com/luben/zstd-jni/releases/tag/v1.5.0-4

Reviewers: David Jacot <djacot@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, Luke Chen <showuon@gmail.com>, Josep Prat <josep.prat@aiven.io>

Co-authored-by: Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants