KAFKA-2430; Listing of PR commits in commit message should be optional #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kafka-trunk-git-pr #137 SUCCESS |
|
@ijuma It seems contains some irrelevant changes from other JIRAs on ProducerSendThread.scala and CoreUtils.scala. |
If there is a single commit in the PR, then it's never listed.
ijuma
force-pushed
the
kafka-2430-optional-listing-commits
branch
from
207ba2e
to
64f1aec
Compare
|
Sorry @guozhangwang, it seems like some changes from testing the script were included accidentally (not sure how I didn't see that). Fixed. |
|
Thanks, LGTM! |
|
kafka-trunk-git-pr #138 SUCCESS |
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Feb 28, 2017
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Mar 2, 2017
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Mar 3, 2017
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Mar 9, 2017
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Mar 10, 2017
apurvam
pushed a commit
to apurvam/kafka
that referenced
this pull request
Mar 15, 2017
ijuma
pushed a commit
to ijuma/kafka
that referenced
this pull request
Mar 22, 2017
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
Mar 22, 2017
radai-rosenblatt
pushed a commit
to radai-rosenblatt/kafka
that referenced
this pull request
Apr 22, 2021
TICKET = LI_DESCRIPTION = 1. For the tests regarding the AlterLogDirs request, When parallelizing the LeaderAndIsr request processing, we disabled the AlterLogDirs request so that they are always rejected. This PR fixes the broken test introduced by the change. 2. The testMetricsDuringTopicCreateDelete has been flaky, and sometimes fails with a URP count of 1 instead of the expected value 0 3. Not sure why testUnsupportedTLSVersion has been failing on CI, but passing on a local dev box. Disabling it for now. EXIT_CRITERIA = 1. If/when we need to re-enable the JBOD features and the AlterLogDirs request. 2 and 3: when these tests are made more robust.
radai-rosenblatt
pushed a commit
to radai-rosenblatt/kafka
that referenced
this pull request
May 12, 2021
[LI-HOTFIX] Backporting Fixing tests (apache#136) TICKET = LI_DESCRIPTION = This patch adds log for admin client listTopic failure and manually backports some test case changes in 2.4 (apache#136) 1. For the tests regarding the AlterLogDirs request, When parallelizing the LeaderAndIsr request processing, we disabled the AlterLogDirs request so that they are always rejected. This PR fixes the broken test introduced by the change. 2. The testMetricsDuringTopicCreateDelete has been flaky, and sometimes fails with a URP count of 1 instead of the expected value 0 3. Not sure why testUnsupportedTLSVersion has been failing on CI, but passing on a local dev box. Disabling it for now. EXIT_CRITERIA = 1. If/when we need to re-enable the JBOD features and the AlterLogDirs request. 2 and 3: when these tests are made more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a single commit in the PR, then it's never listed.