Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
KAFKA-3765; Kafka Code style corrections #1442
Thanks for the PR @rekhajoshm. It's mostly fine although I still see many examples where
Also, can you please update the PR title to follow our convention as described here https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes? Something like:
Finally, the PR description doesn't have to repeat the PR title and please update it so that it doesn't include "using slength where optimum instead of size".
done, please check.thanks @ijuma