Skip to content

KAFKA-17322: Document required header versions in Protocol Guide#16867

Merged
jlprat merged 1 commit intoapache:trunkfrom
ivanyu:update-doc-request-response-headers
Sep 16, 2024
Merged

KAFKA-17322: Document required header versions in Protocol Guide#16867
jlprat merged 1 commit intoapache:trunkfrom
ivanyu:update-doc-request-response-headers

Conversation

@ivanyu
Copy link
Contributor

@ivanyu ivanyu commented Aug 13, 2024

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ivanyu ivanyu force-pushed the update-doc-request-response-headers branch from af9c58b to b2831e1 Compare August 13, 2024 04:10
@ivanyu ivanyu changed the title KAFKA-17322: Document required header versions KAFKA-17322: Document required header versions in Protocol Guide Aug 13, 2024
@ivanyu ivanyu marked this pull request as ready for review August 13, 2024 16:05
@jlprat
Copy link
Contributor

jlprat commented Sep 16, 2024

I ran the tests locally and they ran successfully.

Copy link
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ivanyu

@jlprat jlprat merged commit d0f4d69 into apache:trunk Sep 16, 2024
@ivanyu ivanyu deleted the update-doc-request-response-headers branch December 25, 2024 07:33
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants