From 0bd8796063677349da4ee34f4bb3f24bcde193c1 Mon Sep 17 00:00:00 2001 From: ybyzek Date: Wed, 31 Aug 2016 09:51:19 -0400 Subject: [PATCH] onCompletion: metadata valid only if no exception --- .../org/apache/kafka/clients/producer/KafkaProducer.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java index 05d937754aad8..fbc1099a12206 100644 --- a/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java +++ b/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java @@ -391,9 +391,11 @@ public Future send(ProducerRecord record) { * producer.send(myRecord, * new Callback() { * public void onCompletion(RecordMetadata metadata, Exception e) { - * if(e != null) - * e.printStackTrace(); - * System.out.println("The offset of the record we just sent is: " + metadata.offset()); + * if(e != null) { + * e.printStackTrace(); + * } else { + * System.out.println("The offset of the record we just sent is: " + metadata.offset()); + * } * } * }); * }