Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-4160: Ensure rebalance listener not called with coordinator lock #1855

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@hachikuji
Copy link
Contributor

commented Sep 14, 2016

No description provided.

@hachikuji

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2016

Review by @guozhangwang

@guozhangwang
Copy link
Contributor

left a comment

Just one clarification question, otherwise LGTM.

@@ -352,6 +332,44 @@ else if (!future.isRetriable())
}
}

private synchronized void resetJoinGroupFuture() {
this.joinFuture = null;

This comment has been minimized.

Copy link
@guozhangwang

guozhangwang Sep 15, 2016

Contributor

Where could joinFuture be accessed by the heartbeat thread? Do we need to guard it?

This comment has been minimized.

Copy link
@hachikuji

hachikuji Sep 15, 2016

Author Contributor

I was concerned that the join group response handler could get invoked from the background thread (e.g. if the user calls wakeup() before the join finishes), but I guess that should be impossible since we disable the heartbeat thread prior to beginning the join and we don't reenable it until it returns. Does that sound right?

This comment has been minimized.

Copy link
@guozhangwang

guozhangwang Sep 15, 2016

Contributor

Yeah sounds good to me.

@asfgit asfgit closed this in f197ad4 Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.