New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Windows script 'kafka-consumer-groups.bat' as issue Kafka-4310 mentions #2037

Closed
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
3 participants
@huxihx
Contributor

huxihx commented Oct 18, 2016

add file 'kafka-consumer-groups.bat' for Windows platform

@hachikuji

This comment has been minimized.

Show comment
Hide comment
@hachikuji

hachikuji Oct 18, 2016

Contributor

Thanks for catching this. LGTM.

Contributor

hachikuji commented Oct 18, 2016

Thanks for catching this. LGTM.

@hachikuji

This comment has been minimized.

Show comment
Hide comment
@hachikuji

hachikuji Oct 18, 2016

Contributor

@vahidhashemian Mind doing a quick sanity check on this? I recall you've been doing some testing in a windows environment.

Contributor

hachikuji commented Oct 18, 2016

@vahidhashemian Mind doing a quick sanity check on this? I recall you've been doing some testing in a windows environment.

@vahidhashemian

This comment has been minimized.

Show comment
Hide comment
@vahidhashemian

vahidhashemian Oct 18, 2016

Contributor

@hachikuji Sure, I'll take a look today.

Contributor

vahidhashemian commented Oct 18, 2016

@hachikuji Sure, I'll take a look today.

@vahidhashemian

This comment has been minimized.

Show comment
Hide comment
@vahidhashemian

vahidhashemian Oct 18, 2016

Contributor

I ran a couple of quick tests on Windows and did not notice any issues. LGTM.

Contributor

vahidhashemian commented Oct 18, 2016

I ran a couple of quick tests on Windows and did not notice any issues. LGTM.

@hachikuji

This comment has been minimized.

Show comment
Hide comment
@hachikuji

hachikuji Oct 18, 2016

Contributor

Thanks Vahid, merging to trunk.

Contributor

hachikuji commented Oct 18, 2016

Thanks Vahid, merging to trunk.

@asfgit asfgit closed this in 6f842c1 Oct 18, 2016

@huxihx

This comment has been minimized.

Show comment
Hide comment
@huxihx

huxihx Oct 18, 2016

Contributor

Since I am a new contributor, sorry for the stupid question: Does this mean I can safely close the issue in JIRA?

Contributor

huxihx commented Oct 18, 2016

Since I am a new contributor, sorry for the stupid question: Does this mean I can safely close the issue in JIRA?

@hachikuji

This comment has been minimized.

Show comment
Hide comment
@hachikuji

hachikuji Oct 18, 2016

Contributor

I think I already did, but feel free to do it if I forgot.

Contributor

hachikuji commented Oct 18, 2016

I think I already did, but feel free to do it if I forgot.

@huxihx huxihx deleted the huxihx:kafka-4310_add_consumer_groups_script branch Oct 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment