KAFKA-17076: retain last batch in each round of cleaning (#17193) #20535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In each round of cleaning, retain the last batch even if it's empty, so that logEndOffset info will not get lost after compaction. Reviewers: Jun Rao <junrao@gmail.com>
FrankYang0529
approved these changes
Nov 10, 2025
Member
FrankYang0529
left a comment
FrankYang0529
left a comment
There was a problem hiding this comment.
LGTM. Thanks for help to backport the PR.
chia7712
approved these changes
Nov 21, 2025
Member
|
the flaky pass on my local. will merge it to 3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In each round of cleaning, retain the last batch even if it's empty, so that logEndOffset info will not get lost after compaction.
Reviewers: Jun Rao junrao@gmail.com, PoAn Yang payang@apache.org, Chia-Ping Tsai chia7712@gmail.com