Skip to content

MINOR: BrokerApiVersionsCommandTest does not test multiple broker #20597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

MINOR: BrokerApiVersionsCommandTest does not test multiple broker #20597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions tools/src/test/java/org/apache/kafka/tools/BrokerApiVersionsCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,30 @@
})
public class BrokerApiVersionsCommandTest {
@ClusterTest
public void testBrokerApiVersionsCommandOutput(ClusterInstance clusterInstance) {
public void testSingleBrokerApiVersionsCommandOutput(ClusterInstance clusterInstance) {
String output = ToolsTestUtils.grabConsoleOutput(() ->
BrokerApiVersionsCommand.mainNoExit("--bootstrap-server", clusterInstance.bootstrapServers()));

Iterator<String> lineIter = Arrays.stream(output.split("\n")).iterator();
validateApiVersionCommand(ApiMessageType.ListenerType.BROKER, lineIter);
assertFalse(lineIter.hasNext());
}

@ClusterTest(brokers = 3)
public void testMultiBrokerApiVersionsCommandOutput(ClusterInstance clusterInstance) {
String output = ToolsTestUtils.grabConsoleOutput(() ->
BrokerApiVersionsCommand.mainNoExit("--bootstrap-server", clusterInstance.bootstrapServers()));
Iterator<String> lineIter = Arrays.stream(output.split("\n")).iterator();
assertTrue(lineIter.hasNext());
assertEquals(clusterInstance.bootstrapServers() + " (id: 0 rack: null isFenced: false) -> (", lineIter.next());
for (int i = 0; i < 3; i++) {
validateApiVersionCommand(ApiMessageType.ListenerType.BROKER, lineIter);
}
assertFalse(lineIter.hasNext());
}

ApiMessageType.ListenerType listenerType = ApiMessageType.ListenerType.BROKER;
private static void validateApiVersionCommand(ApiMessageType.ListenerType listenerType, Iterator<String> lineIter) {
String expectedOutput = "localhost:\\d+ \\(id: \\d+ rack: null isFenced: false\\) -> \\(";
assertTrue(lineIter.next().matches(expectedOutput));

NodeApiVersions nodeApiVersions = new NodeApiVersions(
ApiVersionsResponse.filterApis(listenerType, true, true),
Expand Down Expand Up @@ -83,7 +99,7 @@ public void testBrokerApiVersionsCommandOutput(ClusterInstance clusterInstance)
}
assertTrue(lineIter.hasNext());
assertEquals(")", lineIter.next());
assertFalse(lineIter.hasNext());

}

@ClusterTest
Expand Down