Skip to content

KAFKA-19821: Duplicated batches should be logged #20740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2025
Merged

KAFKA-19821: Duplicated batches should be logged #20740

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
155d326
MINOR: add duplicate batch detection logging
brandboat Oct 21, 2025
eb2b56e
Address comments
brandboat Oct 22, 2025
b30ba19
Address comments
brandboat Oct 22, 2025
56b0206
Merge remote-tracking branch 'origin/trunk' into minor-add-log-duplic…
brandboat Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,6 +1214,8 @@ private LogAppendInfo append(MemoryRecords records,
appendInfo.setLastOffset(duplicate.lastOffset());
appendInfo.setLogAppendTime(duplicate.timestamp());
appendInfo.setLogStartOffset(logStartOffset);
logger.trace("Duplicate batch detected, returning AppendInfo from duplicate batch with last offset: {}, first offset: {}, next offset: {}, skipped messages: {}",
appendInfo.lastOffset(), appendInfo.firstOffset(), localLog.logEndOffset(), validRecords);
} else {
// Append the records, and increment the local log end offset immediately after the append because a
// write to the transaction index below may fail, and we want to ensure that the offsets
Expand Down