MINOR: Fix rare flaky behaviour in testPreferredReplicaElection #20976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
josefk31
approved these changes
Nov 24, 2025
Contributor
josefk31
left a comment
josefk31
left a comment
There was a problem hiding this comment.
Thanks for change - LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testPreferredReplicaElectiontest shows rare flakiness by failingwith this error
X replica(s) could not be elected. This occursbecause the test uses
--all-topic-partitions, which attempts preferredleader election on all internal topics as well as the test topic which
creates some timing issue. While the test waits for the test topic to
join the ISR, it does not wait for all internal topics to synchronize
their ISR membership after the broker restart. This fix modifies the
test to target only the specific test topic partition rather than all
partitions.
Reviewers: Jonah Hooper jhooper@confluent.io, kevin-wu24 66326898+kevin-wu24@users.noreply.github.com, David Arthur mumrah@gmail.com