MINOR: PartitionInfo toString corrected #2306
Conversation
kamalcph
commented
Jan 4, 2017
kamalcph
commented
- Removed the extra ',' character while printing the replicas / in-sync replicas identifier
- Removed the extra ',' character while printing the replicas / in-sync replicas identifier
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks for the PR. Can you please add a unit test? Since the original bug eluded us, it indicates that a simple test that validates the output would be useful. |
| @@ -80,13 +80,10 @@ public String toString() { | |||
| /* Extract the node ids from each item in the array and format for display */ | |||
| private String fmtNodeIds(Node[] nodes) { | |||
There was a problem hiding this comment.
Can you please rename this to formatNodeIds. The name is unnecessarily cryptic (unrelated to this PR, I know).
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
- Removed the extra ',' character while printing the replicas / in-sync replicas identifier - PartitionInfoTest added for `toString` method. - Renamed the method 'fmtNodeIds' to 'formatNodeIds'
|
Updated the method name and unit test added. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM, thanks. Merged to trunk. |
Removed the extra ',' character while printing the replicas / in-sync replicas array. Author: Kamal <kamal@nmsworks.co.in> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2306 from Kamal15/trunk
