New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-4794: Add access to OffsetStorageReader from SourceConnector #2604

Open
wants to merge 1 commit into
base: trunk
from

Conversation

Projects
None yet
6 participants
@fhussonnois
Contributor

fhussonnois commented Feb 27, 2017

This a first attempt to implement Add access to OffsetStorageReader from Source Connector.
I am not sure if I did it right so I prefer to ask you your feedback. I still need to write some tests.

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1867/
Test PASSed (JDK 8 and Scala 2.11).

asfbot commented Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/1867/
Test PASSed (JDK 8 and Scala 2.11).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1864/
Test PASSed (JDK 7 and Scala 2.10).

asfbot commented Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/1864/
Test PASSed (JDK 7 and Scala 2.10).

@asfbot

This comment has been minimized.

Show comment
Hide comment
@asfbot

asfbot Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1865/
Test PASSed (JDK 8 and Scala 2.12).

asfbot commented Feb 27, 2017

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/1865/
Test PASSed (JDK 8 and Scala 2.12).

@hleb-albau

This comment has been minimized.

Show comment
Hide comment
@hleb-albau

hleb-albau Aug 24, 2017

Will this path be merged?

hleb-albau commented Aug 24, 2017

Will this path be merged?

@fhussonnois

This comment has been minimized.

Show comment
Hide comment
@fhussonnois

fhussonnois Aug 31, 2017

Contributor

Hi @rhauch, this PR has been updated regarding the KIP-131

Contributor

fhussonnois commented Aug 31, 2017

Hi @rhauch, this PR has been updated regarding the KIP-131

@fhussonnois

This comment has been minimized.

Show comment
Hide comment
@fhussonnois

fhussonnois Sep 5, 2017

Contributor

Thank you @rhauch for your comments. I've updated the PR.

Contributor

fhussonnois commented Sep 5, 2017

Thank you @rhauch for your comments. I've updated the PR.

Show outdated Hide outdated connect/api/src/main/java/org/apache/kafka/connect/connector/Connector.java
Show outdated Hide outdated ...rc/main/java/org/apache/kafka/connect/source/SourceConnectorContext.java
connector.initialize(new SinkConnectorContext() {
@Override
public void requestTaskReconfiguration() {
delegateCtx.requestTaskReconfiguration();

This comment has been minimized.

@rhauch

rhauch Sep 5, 2017

Contributor

Why use the delegate? Why not just call the methods on the WorkerConnector's fields from within the SourceConnectorContext and SinkConnectorContext methods? E.g.,

  @Override
  public void requestTaskReconfiguration() {
       ctx.requestTaskReconfiguration();
  }
@rhauch

rhauch Sep 5, 2017

Contributor

Why use the delegate? Why not just call the methods on the WorkerConnector's fields from within the SourceConnectorContext and SinkConnectorContext methods? E.g.,

  @Override
  public void requestTaskReconfiguration() {
       ctx.requestTaskReconfiguration();
  }

This comment has been minimized.

@fhussonnois

fhussonnois Sep 5, 2017

Contributor

It is to keep the same logic as the raiseError() method. The delegate implements the ConnectorContext.

@fhussonnois

fhussonnois Sep 5, 2017

Contributor

It is to keep the same logic as the raiseError() method. The delegate implements the ConnectorContext.

This comment has been minimized.

@rhauch

rhauch Sep 5, 2017

Contributor

ok

@rhauch

rhauch Sep 5, 2017

Contributor

ok

@fhussonnois

This comment has been minimized.

Show comment
Hide comment
@fhussonnois

fhussonnois Sep 7, 2017

Contributor

@rhauch is there anything I should add or modify for the PR ?

Contributor

fhussonnois commented Sep 7, 2017

@rhauch is there anything I should add or modify for the PR ?

@rhauch

This comment has been minimized.

Show comment
Hide comment
@rhauch

rhauch Sep 7, 2017

Contributor

@fhussonnois, I just submitted the KIP for a vote, which will be open for a few days. This can be merged once that is approved.

Contributor

rhauch commented Sep 7, 2017

@fhussonnois, I just submitted the KIP for a vote, which will be open for a few days. This can be merged once that is approved.

@ewencp ewencp added the connect label Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment