From eadfde7664799f7862bb5516b565d0889391a9a2 Mon Sep 17 00:00:00 2001 From: Kamal C Date: Sat, 19 Aug 2017 12:12:01 +0530 Subject: [PATCH 1/2] MINOR: Typographical error corrected in the StreamsBuilder Javadoc. --- .../kafka/clients/CommonClientConfigs.java | 4 ++-- .../apache/kafka/streams/StreamsBuilder.java | 24 +++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java b/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java index 8634bb3a577db..f51c36a71b51f 100644 --- a/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java +++ b/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java @@ -59,7 +59,7 @@ public class CommonClientConfigs { public static final String RECONNECT_BACKOFF_MS_DOC = "The base amount of time to wait before attempting to reconnect to a given host. This avoids repeatedly connecting to a host in a tight loop. This backoff applies to all connection attempts by the client to a broker."; public static final String RECONNECT_BACKOFF_MAX_MS_CONFIG = "reconnect.backoff.max.ms"; - public static final String RECONNECT_BACKOFF_MAX_MS_DOC = "The maximum amount of time in milliseconds to wait when reconnectng to a broker that has repeatedly failed to connect. If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms."; + public static final String RECONNECT_BACKOFF_MAX_MS_DOC = "The maximum amount of time in milliseconds to wait when reconnecting to a broker that has repeatedly failed to connect. If provided, the backoff per host will increase exponentially for each consecutive connection failure, up to this maximum. After calculating the backoff increase, 20% random jitter is added to avoid connection storms."; public static final String RETRY_BACKOFF_MS_CONFIG = "retry.backoff.ms"; public static final String RETRY_BACKOFF_MS_DOC = "The amount of time to wait before attempting to retry a failed request to a given topic partition. This avoids repeatedly sending requests in a tight loop under some failure scenarios."; @@ -99,7 +99,7 @@ private static List nonTestingSecurityProtocolNames() { /** * Postprocess the configuration so that exponential backoff is disabled when reconnect backoff - * is explicitly configured but the maximum reconnect backoff is not cexplicitly onfigured. + * is explicitly configured but the maximum reconnect backoff is not explicitly configured. * * @param config The config object. * @param parsedValues The parsedValues as provided to postProcessParsedConfig. diff --git a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java index f91aca46e015a..5fc6a55c183ef 100644 --- a/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java +++ b/streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java @@ -63,7 +63,7 @@ public class StreamsBuilder { * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param topics the topic names; must contain at least one topic name @@ -81,7 +81,7 @@ public synchronized KStream stream(final String... topics) { * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the specified topics if no valid committed @@ -103,7 +103,7 @@ public synchronized KStream stream(final Topology.AutoOffsetReset o * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param topicPattern the pattern to match for topic names @@ -122,7 +122,7 @@ public synchronized KStream stream(final Pattern topicPattern) { * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the matched topics if no valid committed @@ -143,7 +143,7 @@ public synchronized KStream stream(final Topology.AutoOffsetReset o * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param keySerde key serde used to read this source {@link KStream}, @@ -166,7 +166,7 @@ public synchronized KStream stream(final Serde keySerde, * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the specified topics if no valid committed @@ -192,7 +192,7 @@ public synchronized KStream stream(final Topology.AutoOffsetReset o * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param timestampExtractor the stateless timestamp extractor used for this source {@link KStream}, @@ -217,7 +217,7 @@ public synchronized KStream stream(final TimestampExtractor timesta * If multiple topics are specified there is no ordering guarantee for records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the specified topics @@ -248,7 +248,7 @@ public synchronized KStream stream(final Topology.AutoOffsetReset o * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param keySerde key serde used to read this source {@link KStream}, @@ -272,7 +272,7 @@ public synchronized KStream stream(final Serde keySerde, * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the matched topics if no valid committed @@ -299,7 +299,7 @@ public synchronized KStream stream(final Topology.AutoOffsetReset o * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param timestampExtractor the stateless timestamp extractor used for this source {@link KStream}, @@ -325,7 +325,7 @@ public synchronized KStream stream(final TimestampExtractor timesta * them and there is no ordering guarantee between records from different topics. *

* Note that the specified input topics must be partitioned by key. - * If this is not the case it is the user's responsibility to repartition the date before any key based operation + * If this is not the case it is the user's responsibility to repartition the data before any key based operation * (like aggregation or join) is applied to the returned {@link KStream}. * * @param offsetReset the {@code "auto.offset.reset"} policy to use for the matched topics if no valid From 9629a06841f4f67c7f1e101262d077c45b59be94 Mon Sep 17 00:00:00 2001 From: Kamal C Date: Sat, 19 Aug 2017 13:24:32 +0530 Subject: [PATCH 2/2] Resolved the intellij doc warning - deprecated method usage removed from ForeachAction @See tag. --- .../main/java/org/apache/kafka/streams/TopologyDescription.java | 2 +- .../java/org/apache/kafka/streams/kstream/ForeachAction.java | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java b/streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java index 725b7b7b06ce4..1b520c64018a4 100644 --- a/streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java +++ b/streams/src/main/java/org/apache/kafka/streams/TopologyDescription.java @@ -57,7 +57,7 @@ interface Subtopology { /** * Represents a {@link Topology#addGlobalStore(org.apache.kafka.streams.processor.StateStoreSupplier, String, * org.apache.kafka.common.serialization.Deserializer, org.apache.kafka.common.serialization.Deserializer, String, - * String, ProcessorSupplier)} global store}. + * String, org.apache.kafka.streams.processor.ProcessorSupplier)} global store}. * Adding a global store results in adding a source node and one stateful processor node. * Note, that all added global stores form a single unit (similar to a {@link Subtopology}) even if different * global stores are not connected to each other. diff --git a/streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java b/streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java index 3e48d79e957e1..42bba28d13b43 100644 --- a/streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java +++ b/streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java @@ -28,7 +28,6 @@ * @param key type * @param value type * @see KStream#foreach(ForeachAction) - * @see KTable#foreach(ForeachAction) */ public interface ForeachAction {