Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-5771: org.apache.kafka.streams.state.internals.Segments#segments method returns incorrect results when segments were added out of order #3737

Closed
wants to merge 1 commit into from

Conversation

radzish
Copy link
Contributor

@radzish radzish commented Aug 25, 2017

Suggested fix for the bug

…s method returns incorrect results when segments were added out of order
Copy link
Contributor

@dguy dguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radzish, LGTM

@dguy
Copy link
Contributor

dguy commented Aug 25, 2017

The 2 test failures are known flakey tests

asfgit pushed a commit that referenced this pull request Aug 25, 2017
…s method returns incorrect results when segments were added out of order

Suggested fix for the bug

Author: radzish <radzish@gmail.com>

Reviewers: Damian Guy <damian.guy@gmail.com>

Closes #3737 from radzish/KAFKA-5771

(cherry picked from commit 05e3850)
Signed-off-by: Damian Guy <damian.guy@gmail.com>
@dguy
Copy link
Contributor

dguy commented Aug 25, 2017

merged to trunk and cherry picked to 0.11

@asfgit asfgit closed this in 05e3850 Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants