KAFKA-5931: deprecate KTable#through and KTable#to #3903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @dguy just one meta comment. Do want to add |
|
@bbejeck problem is the link tags don't work like that, so it would have to be |
|
retest this please |
|
LGTM. Feel free to merge after Jenkins passed. |
mjsax
reviewed
Sep 20, 2017
| * The store name must be a valid Kafka topic name and cannot contain characters other than ASCII alphanumerics, '.', '_' and '-'. | ||
| * | ||
| * @param topic the topic name | ||
| * @param queryableStoreName the state store name used for the result {@code KTable}; valid characters are ASCII | ||
| * alphanumerics, '.', '_' and '-'. If {@code null} this is the equivalent of {@link KTable#through(String)()} | ||
| * @return a {@code KTable} that contains the exact same (and potentially repartitioned) records as this {@code KTable} | ||
| * @deprecated use {@link #toStream()} |
There was a problem hiding this comment.
use {@link #toStream()} followed by {@link KStream#to(String)} and {@link StreamsBuilder#table(String)} to read back as a {@code KTable} ??
same below
|
merged to trunk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.