From 7bb08997d9bd387875df6e18244ab48ac4e5f4d5 Mon Sep 17 00:00:00 2001 From: Ewen Cheslack-Postava Date: Tue, 21 Nov 2017 11:01:56 -0800 Subject: [PATCH 1/2] MINOR: Update Powermock to fix PushHttpMetricsReporterTest failures --- gradle/dependencies.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle index 862ebcba496e..5d145e17ed9f 100644 --- a/gradle/dependencies.gradle +++ b/gradle/dependencies.gradle @@ -60,7 +60,7 @@ versions += [ junit: "4.12", lz4: "1.3.0", metrics: "2.2.0", - powermock: "1.6.4", + powermock: "2.0.0-beta.5", reflections: "0.9.11", rocksDB: "5.0.1", scalaTest: "3.0.2", From b6bb4ec143bc07a5e38eae347300b3a46d963c98 Mon Sep 17 00:00:00 2001 From: Ewen Cheslack-Postava Date: Tue, 21 Nov 2017 11:35:25 -0800 Subject: [PATCH 2/2] Update WorkerTest for new PowerMock --- .../kafka/connect/runtime/WorkerTest.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java index 7fad7c1862b5..a807a308d1b2 100644 --- a/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java +++ b/connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java @@ -43,11 +43,12 @@ import org.apache.kafka.connect.util.ThreadedTest; import org.easymock.Capture; import org.easymock.EasyMock; -import org.easymock.Mock; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; import org.powermock.api.easymock.PowerMock; +import org.powermock.api.easymock.annotation.Mock; +import org.powermock.api.easymock.annotation.MockStrict; import org.powermock.core.classloader.annotations.PowerMockIgnore; import org.powermock.core.classloader.annotations.PrepareForTest; import org.powermock.modules.junit4.PowerMockRunner; @@ -76,15 +77,17 @@ public class WorkerTest extends ThreadedTest { private Worker worker; @Mock - private Plugins plugins = PowerMock.createMock(Plugins.class); + private Plugins plugins; @Mock - private PluginClassLoader pluginLoader = PowerMock.createMock(PluginClassLoader.class); + private PluginClassLoader pluginLoader; @Mock - private DelegatingClassLoader delegatingLoader = - PowerMock.createMock(DelegatingClassLoader.class); - private OffsetBackingStore offsetBackingStore = PowerMock.createMock(OffsetBackingStore.class); - private TaskStatus.Listener taskStatusListener = PowerMock.createStrictMock(TaskStatus.Listener.class); - private ConnectorStatus.Listener connectorStatusListener = PowerMock.createStrictMock(ConnectorStatus.Listener.class); + private DelegatingClassLoader delegatingLoader; + @Mock + private OffsetBackingStore offsetBackingStore; + @MockStrict + private TaskStatus.Listener taskStatusListener; + @MockStrict + private ConnectorStatus.Listener connectorStatusListener; @Before public void setup() {