New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Improve runtime / storage / metrics / config parts #4525

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@asdf2014
Member

asdf2014 commented Feb 5, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify documentation (including upgrade notes)
  • Verify test coverage and CI build status
@asfgit

This comment has been minimized.

asfgit commented Feb 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/324/

@asfgit

This comment has been minimized.

asfgit commented Feb 6, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/361/

@asdf2014 asdf2014 changed the title from [WIP] Improve runtime / storage / metrics / config parts to [MINOR] Improve runtime / storage / metrics / config parts Feb 7, 2018

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 8, 2018

Hi, @ijuma @guozhangwang . PTAL.

@guozhangwang

This comment has been minimized.

Contributor

guozhangwang commented Feb 8, 2018

There is a checkstyle failure:

11:26:42 :connect:runtime:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk9-scala2.12/connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java:29: Using the '.*' form of import should be avoided - org.apache.kafka.connect.storage.*. [AvoidStarImport]
@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 9, 2018

@guozhangwang Thank you for comment. Already fixed.

@guozhangwang

This comment has been minimized.

Contributor

guozhangwang commented Feb 9, 2018

retest this please

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 11, 2018

@guozhangwang Fixed conflicts and rebased those commits onto trunk branch. PTAL.

@guozhangwang

This comment has been minimized.

Contributor

guozhangwang commented Feb 12, 2018

Jenkins failures from org.apache.kafka.connect.runtime.WorkerSinkTaskThreadedTest.testAssignmentPauseResume
seem related:

Error Message

org.apache.kafka.connect.errors.ConnectException: Exiting WorkerSinkTask due to unrecoverable exception.
@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 13, 2018

@guozhangwang Finally, all checks have passed. PTAL.

@guozhangwang guozhangwang merged commit 2693e9b into apache:trunk Feb 14, 2018

3 checks passed

JDK 7 and Scala 2.11 SUCCESS 8590 tests run, 17 skipped, 0 failed.
Details
JDK 8 and Scala 2.12 SUCCESS 8590 tests run, 17 skipped, 0 failed.
Details
JDK 9 and Scala 2.12 SUCCESS 8590 tests run, 17 skipped, 0 failed.
Details
@guozhangwang

This comment has been minimized.

Contributor

guozhangwang commented Feb 14, 2018

Merged to trunk. Thanks @asdf2014

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Feb 14, 2018

@guozhangwang You are welcome :D

@asdf2014 asdf2014 deleted the asdf2014:improve branch Feb 14, 2018

huxihx added a commit to huxihx/kafka that referenced this pull request Mar 13, 2018

jcustenborder added a commit to jcustenborder/kafka that referenced this pull request May 16, 2018

umesh9794 added a commit to umesh9794/kafka that referenced this pull request Jun 5, 2018

nimosunbit added a commit to sunbit-dev/kafka that referenced this pull request Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment