Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-6871: KStreams Scala API: incorrect Javadocs and misleading parameter name #4971

Merged
merged 1 commit into from May 7, 2018

Conversation

@miguno
Copy link
Contributor

commented May 7, 2018

See PR title. This is a minor fix.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@mjsax
mjsax approved these changes May 7, 2018
Copy link
Member

left a comment

LGTM.

*
* @param transformerSupplier a instance of `TransformerSupplier` that generates a `Transformer`
* @param transformer the `Transformer` instance
* @param stateStoreNames the names of the state stores used by the processor

This comment has been minimized.

Copy link
@mjsax

mjsax May 7, 2018

Member

nit: align idention

@mjsax mjsax added the streams label May 7, 2018
@mjsax mjsax requested review from mjsax and guozhangwang May 7, 2018
@mjsax

This comment has been minimized.

Copy link
Member

commented May 7, 2018

@debasishg

This comment has been minimized.

Copy link
Contributor

commented May 7, 2018

LGTM

Copy link
Contributor

left a comment

Thanks, @mjsax LGTM

@mjsax

This comment has been minimized.

Copy link
Member

commented May 7, 2018

@bbejeck It's not my PR -- thanks goes to @miguno :)

@mjsax mjsax merged commit 00d1137 into apache:trunk May 7, 2018
3 checks passed
3 checks passed
JDK 10 and Scala 2.12 SUCCESS 8879 tests run, 7 skipped, 0 failed.
Details
JDK 7 and Scala 2.11 SUCCESS 8879 tests run, 7 skipped, 0 failed.
Details
JDK 8 and Scala 2.12 SUCCESS 8879 tests run, 7 skipped, 0 failed.
Details
@mjsax

This comment has been minimized.

Copy link
Member

commented May 7, 2018

Thanks @miguno ! Merged to trunk

@miguno miguno deleted the miguno:trunk-KAFKA-6871 branch May 7, 2018
@bbejeck

This comment has been minimized.

Copy link
Contributor

commented May 7, 2018

@miguno mea-culpa! Thanks for the PR

ying-zheng added a commit to ying-zheng/kafka that referenced this pull request Jul 6, 2018
…ameter name (apache#4971)

Reviewer: Matthias J. Sax <matthias@confluent.io>, Debasish Ghosh <dghosh@acm.org>, Guozhang Wang <guozhang@confluent.io>, Bill Bejeck <bill@confluent.io>
nimosunbit added a commit to sunbit-dev/kafka that referenced this pull request Nov 6, 2018
…ameter name (apache#4971)

Reviewer: Matthias J. Sax <matthias@confluent.io>, Debasish Ghosh <dghosh@acm.org>, Guozhang Wang <guozhang@confluent.io>, Bill Bejeck <bill@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.