Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-7559: Correct standalone system tests to use the correct external file #5883

Merged
merged 1 commit into from Nov 6, 2018

Conversation

rhauch
Copy link
Contributor

@rhauch rhauch commented Nov 5, 2018

This fixes the Connect standalone system tests. See branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2021/

This should be backported to the 2.0 branch, since that's when the tests were first modified to use the external property file.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@rhauch
Copy link
Contributor Author

rhauch commented Nov 5, 2018

The branch builder passed. None of the build failures are related to Connect.

Copy link
Contributor

@mageshn mageshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma ijuma merged commit f856082 into apache:trunk Nov 6, 2018
ijuma pushed a commit that referenced this pull request Nov 6, 2018
…al file (#5883)

This fixes the Connect standalone system tests. See branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2021/

This should be backported to the 2.0 branch, since that's when the tests were first
modified to use the external property file.

Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ismael Juma <ismael@juma.me.uk>
ijuma pushed a commit that referenced this pull request Nov 6, 2018
…al file (#5883)

This fixes the Connect standalone system tests. See branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2021/

This should be backported to the 2.0 branch, since that's when the tests were first
modified to use the external property file.

Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ismael Juma <ismael@juma.me.uk>
@ijuma
Copy link
Contributor

ijuma commented Nov 6, 2018

Merged to trunk, 2.1 and 2.0.

Pengxiaolong pushed a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…al file (apache#5883)

This fixes the Connect standalone system tests. See branch builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2021/

This should be backported to the 2.0 branch, since that's when the tests were first
modified to use the external property file.

Reviewers: Magesh Nandakumar <magesh.n.kumar@gmail.com>, Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants