Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8306: Initialize log end offset accurately when start offset is non-zero #6652

Merged
merged 6 commits into from May 4, 2019

Conversation

@dhruvilshah3
Copy link
Contributor

dhruvilshah3 commented Apr 30, 2019

No description provided.

@@ -573,13 +573,13 @@ class Log(@volatile var dir: File,
if (logSegments.isEmpty) {
// no existing segments, create a new mutable segment beginning at offset 0

This comment has been minimized.

Copy link
@ijuma

ijuma Apr 30, 2019

Contributor

Seems like the comment needs to be updated.

Copy link
Contributor

hachikuji left a comment

Thanks for the patch. I had one question.

core/src/main/scala/kafka/log/Log.scala Show resolved Hide resolved
- Add a warning message when deleting segments.
Copy link
Contributor

hachikuji left a comment

LGTM. Thanks for the fix!

@dhruvilshah3

This comment has been minimized.

Copy link
Contributor Author

dhruvilshah3 commented May 3, 2019

Failures look unrelated. Retest this please.

@hachikuji hachikuji merged commit 56b92a5 into apache:trunk May 4, 2019
2 checks passed
2 checks passed
JDK 11 and Scala 2.12 SUCCESS 11023 tests run, 69 skipped, 0 failed.
Details
JDK 8 and Scala 2.11 SUCCESS 11023 tests run, 69 skipped, 0 failed.
Details
hachikuji added a commit that referenced this pull request May 4, 2019
… non-zero (#6652)

This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji added a commit that referenced this pull request May 4, 2019
… non-zero (#6652)

This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji added a commit that referenced this pull request May 4, 2019
… non-zero (#6652)

This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
ijuma added a commit to ijuma/kafka that referenced this pull request May 8, 2019
…s-hashcode

* apache-github/trunk:
  KAFKA-8158: Add EntityType for Kafka RPC fields (apache#6503)
  MINOR: correctly parse version OffsetCommitResponse version < 3
  KAFKA-8284: enable static membership on KStream (apache#6673)
  KAFKA-8304: Fix registration of Connect REST extensions (apache#6651)
  KAFKA-8275; Take throttling into account when choosing least loaded node (apache#6619)
  KAFKA-3522: Interactive Queries must return timestamped stores (apache#6661)
  MINOR: MetricsIntegrationTest should set StreamsConfig.STATE_DIR_CONFIG (apache#6687)
  MINOR: Remove unused field in `ListenerConnectionQuota`
  KAFKA-8131; Move --version implementation into CommandLineUtils (apache#6481)
  KAFKA-8056; Use automatic RPC generation for FindCoordinator (apache#6408)
  MINOR: Remove workarounds for lz4-java bug affecting byte buffers (apache#6679)
  KAFKA-7455: Support JmxTool to connect to a secured RMI port. (apache#5968)
  MINOR: Document improvement (apache#6682)
  MINOR: Fix ThrottledReplicaListValidator doc error. (apache#6537)
  KAFKA-8306; Initialize log end offset accurately when start offset is non-zero (apache#6652)
Pengxiaolong added a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019
… non-zero (apache#6652)

This patch ensures that the log end offset of each partition is initialized consistently with the checkpointed log start offset.

Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.