Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8309: Add Consolidated Connector Endpoint to Connect REST API #6658

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@norwood
Copy link
Contributor

commented May 1, 2019

Add ?expand query param for additional info on /connectors. See KIP-465.

This should only be merged if KIP-465 is approved.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@norwood norwood force-pushed the norwood:KAFKA-8309 branch from 79651d6 to 0f0cdf6 May 1, 2019

@rhauch rhauch changed the title KIP-465: Add Consolidated Connector Endpoint to Connect REST API KAFKA-8309: Add Consolidated Connector Endpoint to Connect REST API May 2, 2019

@rhauch
Copy link
Contributor

left a comment

Thanks, @norwood! Looks good, though I have a few requests for some pretty minor modifications.

@norwood norwood force-pushed the norwood:KAFKA-8309 branch 3 times, most recently from c78d275 to 7d9b22e May 2, 2019

@rhauch
Copy link
Contributor

left a comment

Thanks, @norwood! This is clearer and much smaller change - well done. A few minor suggestions, and one question.

@norwood norwood force-pushed the norwood:KAFKA-8309 branch from 7d9b22e to dd72b76 May 15, 2019

@rhauch
Copy link
Contributor

left a comment

Thanks, @norwood. One suggestion and one change request. Would also be good to run an integration test run with this PR.

@norwood norwood force-pushed the norwood:KAFKA-8309 branch from dd72b76 to 4f32960 May 15, 2019

@norwood

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@norwood norwood force-pushed the norwood:KAFKA-8309 branch from 4f32960 to 64256b8 May 15, 2019

@ijuma

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

Is this ready to be merged?

@rhauch

rhauch approved these changes May 16, 2019

Copy link
Contributor

left a comment

Thanks, @norwood. Nice improvement! LGTM.

@rhauch rhauch merged commit 5a95c2e into apache:trunk May 16, 2019

2 checks passed

JDK 11 and Scala 2.12 SUCCESS 11134 tests run, 69 skipped, 0 failed.
Details
JDK 8 and Scala 2.11 SUCCESS 11134 tests run, 69 skipped, 0 failed.
Details

Pengxiaolong added a commit to Pengxiaolong/kafka that referenced this pull request Jun 14, 2019

Add '?expand' query param for additional info on '/connectors'. (apac…
…he#6658)

Per KIP-465, kept existing behavior of `/connectors` resource in the Connect's REST API, but added the ability to specify `?expand` query parameter to get list of connectors with status details on each connector. Added unit tests, and verified passing existing system tests (which use the older list form).

See https://cwiki.apache.org/confluence/display/KAFKA/KIP-465%3A+Add+Consolidated+Connector+Endpoint+to+Connect+REST+API.

Author: Dan Norwood <norwood@confluent.io>
Reviewer: Randall Hauch <rhauch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.