Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8198 KStreams testing docs use non-existent method pipe #6678

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@ouertani
Copy link
Contributor

commented May 5, 2019

*More detailed description of your change,
Minor fix of #8198 apache/kafka-site#210

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • [X ] Verify documentation (including upgrade notes)
@vvcephei
Copy link
Contributor

left a comment

Thanks!

@dongjinleekr

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

LGTM. Is there anyone who can merge this PR?

cc/ @hachikuji @bbejeck

@bbejeck bbejeck merged commit 8cabd44 into apache:trunk Jul 12, 2019

2 of 3 checks passed

JDK 11 and Scala 2.13 FAILURE 11639 tests run, 67 skipped, 1 failed.
Details
JDK 11 and Scala 2.12 SUCCESS 11023 tests run, 69 skipped, 0 failed.
Details
JDK 8 and Scala 2.11 SUCCESS 11023 tests run, 69 skipped, 0 failed.
Details
@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Merged #6678 into trunk

@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks for the contribution @ouertani!

bbejeck added a commit that referenced this pull request Jul 12, 2019
Fixes #8198 KStreams testing docs use non-existent method pipe (#6678)
Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 12, 2019
Fixes #8198 KStreams testing docs use non-existent method pipe (#6678)
Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 12, 2019
Fixes #8198 KStreams testing docs use non-existent method pipe (#6678)
Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 12, 2019
Fixes #8198 KStreams testing docs use non-existent method pipe (#6678)
Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 12, 2019
Fixes #8198 KStreams testing docs use non-existent method pipe (#6678)
Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

cherry-picked to 2.3, 2.2, 2.1, 2.0 and 1.1

@dongjinleekr

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Congrats, @ouertani! :)

ijuma added a commit to confluentinc/kafka that referenced this pull request Jul 20, 2019
Merge remote-tracking branch 'apache-github/2.3' into ccs-2.3
* apache-github/2.3:
  MINOR: Update documentation for enabling optimizations (apache#7099)
  MINOR: Remove stale streams producer retry default docs. (apache#6844)
  KAFKA-8635; Skip client poll in Sender loop when no request is sent (apache#7085)
  KAFKA-8615: Change to track partition time breaks TimestampExtractor (apache#7054)
  KAFKA-8670; Fix exception for kafka-topics.sh --describe without --topic mentioned (apache#7094)
  KAFKA-8602: Separate PR for 2.3 branch (apache#7092)
  KAFKA-8530; Check for topic authorization errors in OffsetFetch response (apache#6928)
  KAFKA-8662; Fix producer metadata error handling and consumer manual assignment (apache#7086)
  KAFKA-8637: WriteBatch objects leak off-heap memory (apache#7050)
  KAFKA-8620: fix NPE due to race condition during shutdown while rebalancing (apache#7021)
  HOT FIX: close RocksDB objects in correct order (apache#7076)
  KAFKA-7157: Fix handling of nulls in TimestampConverter (apache#7070)
  KAFKA-6605: Fix NPE in Flatten when optional Struct is null (apache#5705)
  Fixes #8198 KStreams testing docs use non-existent method pipe (apache#6678)
  KAFKA-5998: fix checkpointableOffsets handling (apache#7030)
  KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup v0 (apache#7072)
  KAFKA-8591; WorkerConfigTransformer NPE on connector configuration reloading (apache#6991)
  MINOR: add upgrade text (apache#7013)
  Bump version to 2.3.1-SNAPSHOT
xiowu0 added a commit to linkedin/kafka that referenced this pull request Aug 22, 2019
[LI-CHERRY-PICK] [62617b9] Fixes #8198 KStreams testing docs use non-…
…existent method pipe (apache#6678)

TICKET =
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [62617b9]
ORIGINAL_DESCRIPTION =

Minor fix of #8198 apache/kafka-site#210

Reviewers: John Roesler <john@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
(cherry picked from commit 62617b9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.