Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove stale streams producer retry default docs. #6844

Merged
merged 1 commit into from Jul 19, 2019

Conversation

@cwildman
Copy link
Contributor

commented May 30, 2019

As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@cwildman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

I don't have permission to assign reviewers or apply the streams label.
CC: @bbejeck @mjsax

@mjsax
mjsax approved these changes Jun 3, 2019
Copy link
Member

left a comment

LGTM.

Only committers can assign reviews and assign labels. Would you mind to do a PR against https://github.com/apache/kafka-site, too, to get this fixed immediately on the webpage, too?

This should be cherry-picked back to 2.1 when we dropped setting producer retries to 10.

@cwildman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Update to kafka-site: apache/kafka-site#213

@mjsax

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@bbejeck bbejeck merged commit 9829c72 into apache:trunk Jul 19, 2019

2 of 3 checks passed

JDK 8 and Scala 2.11 FAILURE 11292 tests run, 67 skipped, 1 failed.
Details
JDK 11 and Scala 2.12 SUCCESS 11292 tests run, 67 skipped, 0 failed.
Details
JDK 11 and Scala 2.13 SUCCESS 11669 tests run, 67 skipped, 0 failed.
Details
@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Merged #6844 into trunk

bbejeck added a commit that referenced this pull request Jul 19, 2019
MINOR: Remove stale streams producer retry default docs. (#6844)
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>,  Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 19, 2019
MINOR: Remove stale streams producer retry default docs. (#6844)
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>,  Bill Bejeck <bbejeck@gmail.com>
bbejeck added a commit that referenced this pull request Jul 19, 2019
MINOR: Remove stale streams producer retry default docs. (#6844)
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>,  Bill Bejeck <bbejeck@gmail.com>
@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

cherry-picked to 2.3, 2.2, and 2.1

bbejeck added a commit to apache/kafka-site that referenced this pull request Jul 19, 2019
Remove streams default override for producer retries. (#213)
These default overrides are no longer applied, see: apache/kafka#6844.
CC: Updated for 2.2 and 2.1
ijuma added a commit to confluentinc/kafka that referenced this pull request Jul 20, 2019
Merge remote-tracking branch 'apache-github/2.3' into ccs-2.3
* apache-github/2.3:
  MINOR: Update documentation for enabling optimizations (apache#7099)
  MINOR: Remove stale streams producer retry default docs. (apache#6844)
  KAFKA-8635; Skip client poll in Sender loop when no request is sent (apache#7085)
  KAFKA-8615: Change to track partition time breaks TimestampExtractor (apache#7054)
  KAFKA-8670; Fix exception for kafka-topics.sh --describe without --topic mentioned (apache#7094)
  KAFKA-8602: Separate PR for 2.3 branch (apache#7092)
  KAFKA-8530; Check for topic authorization errors in OffsetFetch response (apache#6928)
  KAFKA-8662; Fix producer metadata error handling and consumer manual assignment (apache#7086)
  KAFKA-8637: WriteBatch objects leak off-heap memory (apache#7050)
  KAFKA-8620: fix NPE due to race condition during shutdown while rebalancing (apache#7021)
  HOT FIX: close RocksDB objects in correct order (apache#7076)
  KAFKA-7157: Fix handling of nulls in TimestampConverter (apache#7070)
  KAFKA-6605: Fix NPE in Flatten when optional Struct is null (apache#5705)
  Fixes #8198 KStreams testing docs use non-existent method pipe (apache#6678)
  KAFKA-5998: fix checkpointableOffsets handling (apache#7030)
  KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup v0 (apache#7072)
  KAFKA-8591; WorkerConfigTransformer NPE on connector configuration reloading (apache#6991)
  MINOR: add upgrade text (apache#7013)
  Bump version to 2.3.1-SNAPSHOT
xiowu0 added a commit to linkedin/kafka that referenced this pull request Aug 22, 2019
[LI-CHERRY-PICK] [aa1a285] MINOR: Remove stale streams producer retry…
… default docs. (apache#6844)

TICKET =
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [aa1a285]
ORIGINAL_DESCRIPTION =

As part of apache#5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.

Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>,  Bill Bejeck <bbejeck@gmail.com>
(cherry picked from commit aa1a285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.