Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOT FIX: close RocksDB objects in correct order #7076

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@ableegoldman
Copy link
Contributor

commented Jul 11, 2019

When opening a rocksdb database with column families, things must be closed following a specific order as described here

Should be cherry-picked back to 2.2

@ableegoldman

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

doc
@mjsax
mjsax approved these changes Jul 11, 2019
Copy link
Member

left a comment

LTGM.

@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Thanks for the fix @ableegoldman waiting for green build for merging

@pkleindl

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

LGTM, thanks.

@bbejeck bbejeck added the streams label Jul 12, 2019

@bbejeck

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

retest this please

@mjsax

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Two unrelated know flaky tests failed. Merging as 2 builds are green.

@mjsax mjsax merged commit d2328a1 into apache:trunk Jul 12, 2019

2 of 3 checks passed

JDK 11 and Scala 2.13 FAILURE 11643 tests run, 67 skipped, 2 failed.
Details
JDK 11 and Scala 2.12 SUCCESS 11643 tests run, 67 skipped, 0 failed.
Details
JDK 8 and Scala 2.11 SUCCESS 11643 tests run, 67 skipped, 0 failed.
Details
mjsax added a commit that referenced this pull request Jul 12, 2019
HOT FIX: close RocksDB objects in correct order (#7076)
Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
mjsax added a commit that referenced this pull request Jul 12, 2019
HOT FIX: close RocksDB objects in correct order (#7076)
Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
@mjsax

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Merged to trunk and cherry-picked to 2.3 and 2.2 branches.

@guozhangwang

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

This is a great find. Thanks @ableegoldman

ijuma added a commit to confluentinc/kafka that referenced this pull request Jul 20, 2019
Merge remote-tracking branch 'apache-github/2.3' into ccs-2.3
* apache-github/2.3:
  MINOR: Update documentation for enabling optimizations (apache#7099)
  MINOR: Remove stale streams producer retry default docs. (apache#6844)
  KAFKA-8635; Skip client poll in Sender loop when no request is sent (apache#7085)
  KAFKA-8615: Change to track partition time breaks TimestampExtractor (apache#7054)
  KAFKA-8670; Fix exception for kafka-topics.sh --describe without --topic mentioned (apache#7094)
  KAFKA-8602: Separate PR for 2.3 branch (apache#7092)
  KAFKA-8530; Check for topic authorization errors in OffsetFetch response (apache#6928)
  KAFKA-8662; Fix producer metadata error handling and consumer manual assignment (apache#7086)
  KAFKA-8637: WriteBatch objects leak off-heap memory (apache#7050)
  KAFKA-8620: fix NPE due to race condition during shutdown while rebalancing (apache#7021)
  HOT FIX: close RocksDB objects in correct order (apache#7076)
  KAFKA-7157: Fix handling of nulls in TimestampConverter (apache#7070)
  KAFKA-6605: Fix NPE in Flatten when optional Struct is null (apache#5705)
  Fixes #8198 KStreams testing docs use non-existent method pipe (apache#6678)
  KAFKA-5998: fix checkpointableOffsets handling (apache#7030)
  KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup v0 (apache#7072)
  KAFKA-8591; WorkerConfigTransformer NPE on connector configuration reloading (apache#6991)
  MINOR: add upgrade text (apache#7013)
  Bump version to 2.3.1-SNAPSHOT
xiowu0 added a commit to linkedin/kafka that referenced this pull request Aug 22, 2019
[LI-CHERRY-PICK] [5942700] HOT FIX: close RocksDB objects in correct …
…order (apache#7076)

TICKET =
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [5942700]
ORIGINAL_DESCRIPTION =

Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
(cherry picked from commit 5942700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.