Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: kafkatest - adding whitelist for interbroker sasl configs #7093

Merged
merged 4 commits into from Jul 22, 2019

Conversation

@brianbushree
Copy link
Contributor

commented Jul 15, 2019

forgot to include this line in #7018

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@rajinisivaram
Copy link
Contributor

left a comment

@brianbushree Thanks for the PR. Can we add a method to ListenerSecurityConfig and use that rather than duplicate the checks that need to be kept consistent?

@rajinisivaram
Copy link
Contributor

left a comment

@brianbushree Thanks for the PR, LGTM. Have we run some SASL system tests with these changes? Don't need a full run, but it will be good to run some tests that use SASL listeners.

@brianbushree

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@rajinisivaram still need to do some validation on my end. let me run some tests before we merge

@brianbushree

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

@rajinisivaram the tests seem fine to me ( http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2019-07-19--001.1563561379--brianbushree--interbroker-sasl-fix--4bfb6ff/report.html )

there was one failure but it seems unrelated:

[2019-07-19 17:43:07,405] WARN Client session timed out, have not heard from server in 30008ms for sessionid 0x0 (org.apache.zookeeper.ClientCnxn)
Exception in thread "main" kafka.zookeeper.ZooKeeperClientTimeoutException: Timed out waiting for connection while in state: CONNECTING
	at kafka.zookeeper.ZooKeeperClient.$anonfun$waitUntilConnected$3(ZooKeeperClient.scala:259)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at kafka.utils.CoreUtils$.inLock(CoreUtils.scala:253)
	at kafka.zookeeper.ZooKeeperClient.waitUntilConnected(ZooKeeperClient.scala:255)
	at kafka.zookeeper.ZooKeeperClient.<init>(ZooKeeperClient.scala:113)
	at kafka.zk.KafkaZkClient$.apply(KafkaZkClient.scala:1833)
	at kafka.admin.TopicCommand$ZookeeperTopicService$.apply(TopicCommand.scala:288)
	at kafka.admin.TopicCommand$.main(TopicCommand.scala:54)
	at kafka.admin.TopicCommand.main(TopicCommand.scala)
@rajinisivaram

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@brianbushree Thanks for running the test, merging to trunk.

@rajinisivaram rajinisivaram merged commit e5f7220 into apache:trunk Jul 22, 2019

1 of 3 checks passed

JDK 11 and Scala 2.12 FAILURE 11682 tests run, 67 skipped, 1 failed.
Details
JDK 8 and Scala 2.11 FAILURE 11682 tests run, 67 skipped, 3 failed.
Details
JDK 11 and Scala 2.13 SUCCESS 11682 tests run, 67 skipped, 0 failed.
Details
rajinisivaram added a commit to confluentinc/kafka that referenced this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.