Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Upgrade jackson-databind to 2.9.9.3 #7125

Merged
merged 3 commits into from Aug 7, 2019

Conversation

@ijuma
Copy link
Contributor

commented Jul 28, 2019

2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression introduced
in 2.9.9.2.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested a review from omkreddy Jul 28, 2019

@omkreddy
Copy link
Contributor

left a comment

@ijuma Thanks for the PR. LGTM.

@ijuma

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

retest this please

1 similar comment
@mumrah

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

retest this please

gradle/dependencies.gradle Outdated
@@ -72,6 +72,7 @@ versions += [
httpclient: "4.5.8",
easymock: "4.0.2",
jackson: "2.9.9",
jacksonDatabind: "2.9.9.2",

This comment has been minimized.

Copy link
@arvindth

arvindth Jul 31, 2019

Question on this addition: Instead of hardcoding this version here, perhaps it might be nicer to add a section after this array definition:

# In most cases we want the jackson-databind version to match jackson, unless 
# there's an updated micropatch
# versions["jacksonDatabind"] = versions["jackson"]
versions["jacksonDatabind"] = "2.9.9.2"

That way during the next upgrade to jackson, we mirror the versions, and future jackson upgrades only need to update the main version.

This comment has been minimized.

Copy link
@ijuma

ijuma Aug 1, 2019

Author Contributor

I think that's more likely to cause issues as the two jackson library versions are not near each other.

@ijuma ijuma force-pushed the ijuma:jackson-databind-2.9.9.2 branch to e787bec Aug 6, 2019

@ijuma ijuma changed the title MINOR: Upgrade jackson-databind to 2.9.9.2 MINOR: Upgrade jackson-databind to 2.9.9.3 Aug 6, 2019

@ijuma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@omkreddy Let me know if the updated version looks good.

@ijuma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

retest this please

@omkreddy

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@ijuma upgrade to jackson-databind 2.9.9.3 LGTM. thanks.

@ijuma

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Both JDK 11 builds passed, JDK 8 had an unrelated timeout. Merging to master and cherry-picking to 2.3 and 2.2 branches.

@ijuma ijuma merged commit 97b731b into apache:trunk Aug 7, 2019

2 of 3 checks passed

JDK 8 and Scala 2.11 FAILURE 11591 tests run, 67 skipped, 0 failed.
Details
JDK 11 and Scala 2.12 SUCCESS 11796 tests run, 67 skipped, 0 failed.
Details
JDK 11 and Scala 2.13 SUCCESS 11796 tests run, 67 skipped, 0 failed.
Details

@ijuma ijuma deleted the ijuma:jackson-databind-2.9.9.2 branch Aug 7, 2019

ijuma added a commit that referenced this pull request Aug 7, 2019
MINOR: Upgrade jackson-databind to 2.9.9.3 (#7125)
2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression
introduced in 2.9.9.2.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma added a commit that referenced this pull request Aug 7, 2019
MINOR: Upgrade jackson-databind to 2.9.9.3 (#7125)
2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression
introduced in 2.9.9.2.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
ijuma added a commit to confluentinc/kafka that referenced this pull request Aug 8, 2019
Sync from apache/kafka (8 August 2019) and upgrade avro to 1.9.0
The avro upgrade was needed to fix the following error during
':support-metrics-client:generateAvro':

Caused by: org.apache.velocity.exception.MethodInvocationException: Variable $velocityCount has not been set at /org/apache/avro/compiler/specific/templates/java/classic/record.vm[line 82, column 150]

Conflicts:
 * gradle.properties -> trivial fix, `scalaVersion` is next to `version`, which
 is different in ccs kafka
 * gradle/dependencies.gradle -> reduce divergence with apache kafka by using
 `httpclient` instead of `httpcomponents` from the `versions` array. Remove
 unused `httpmime` and `httpcomponents` from said array.

* apache-github/trunk:
  MINOR: Update dependencies for Kafka 2.4 (apache#7126)
  KAFKA-8599: Use automatic RPC generation in ExpireDelegationToken
  MINOR: Upgrade jackson-databind to 2.9.9.3 (apache#7125)
  MINOR: some small style fixes to RoundRobinPartitioner
  KAFKA-8736: Streams performance improvement, use isEmpty() rather than size() == 0 (apache#7164)
  Minor: Refactor methods to add metrics to sensor in `StreamsMetricsImpl` (apache#7161)
xiowu0 added a commit to linkedin/kafka that referenced this pull request Aug 22, 2019
[LI-CHERRY-PICK] [8e87041] MINOR: Upgrade jackson-databind to 2.9.9.3 (
…apache#7125)

TICKET =
LI_DESCRIPTION =
EXIT_CRITERIA = HASH [8e87041]
ORIGINAL_DESCRIPTION =

2.9.9.1 and 2.9.9.2 include security fixes while 2.9.9.3 fixes a regression
introduced in 2.9.9.2.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
(cherry picked from commit 8e87041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.