Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-8824: bypass value serde on null #7235

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@vvcephei
Copy link
Contributor

commented Aug 21, 2019

In a KTable context, we should not pass null into a user-supplied serde.

Testing: I verified that the change to the test results in test failures without the patch.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)
@vvcephei

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@mjsax or @bbejeck , can you take a look, please? Thanks!

@mjsax mjsax added the streams label Aug 22, 2019

@mjsax
mjsax approved these changes Aug 22, 2019
Copy link
Member

left a comment

LGTM.

@vvcephei

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

java 11/scala 2.13 passed: https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/1163/

java 8 failed with a Connect test: https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/24321/

java 11 / scala 2.12 failed with a Broker test: https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/7111/

Test failures unrelated.

Retest this, please.

@bbejeck
Copy link
Contributor

left a comment

Thanks for the quick turnaround on this @vvcephei LGTM

@guozhangwang guozhangwang merged commit e213608 into apache:trunk Aug 22, 2019

2 of 3 checks passed

JDK 11 and Scala 2.13 FAILURE 11826 tests run, 77 skipped, 1 failed.
Details
JDK 11 and Scala 2.12 SUCCESS 11826 tests run, 77 skipped, 0 failed.
Details
JDK 8 and Scala 2.11 SUCCESS 11826 tests run, 77 skipped, 0 failed.
Details
guozhangwang added a commit that referenced this pull request Aug 22, 2019
KAFKA-8824: bypass value serde on null (#7235)
In a KTable context, we should not pass null into a user-supplied serde.

Testing: I verified that the change to the test results in test failures without the patch.

Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>,
@guozhangwang

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

Cherry-picked to 2.3 with some minor conflict resolved.

@vvcephei

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2019

Thanks, @guozhangwang !

@vvcephei vvcephei deleted the vvcephei:kafka-8824-fix branch Aug 22, 2019

@vvuibert vvuibert referenced this pull request Aug 23, 2019
xiowu0 added a commit to linkedin/kafka that referenced this pull request Aug 27, 2019
[LI-CHERRY-PICK] [9100009] KAFKA-8824: bypass value serde on null (ap…
…ache#7235)

TICKET = KAFKA-8824
LI_DESCRIPTION =

EXIT_CRITERIA = HASH [9100009]
ORIGINAL_DESCRIPTION =

In a KTable context, we should not pass null into a user-supplied serde.

Testing: I verified that the change to the test results in test failures without the patch.

Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>,
(cherry picked from commit 9100009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.