Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker related MOJOs and corresponding example #789

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@jbonofre
Copy link
Member

jbonofre commented Mar 21, 2019

No description provided.

@fpapon

This comment has been minimized.

Copy link
Member

fpapon commented Mar 21, 2019

AWESOME!

@jbonofre jbonofre force-pushed the jbonofre:CLOUD branch from a3561c6 to 139a1f6 Mar 21, 2019

public void execute() throws MojoExecutionException, MojoFailureException {
getLog().info("Creating Docker image");
try {
Process process = new ProcessBuilderFactoryImpl().newBuilder()

This comment has been minimized.

Copy link
@rmannibucau

rmannibucau Mar 22, 2019

Contributor

Tink you need to optionally log in before ;)
Also it can be worth using jib to control the layers properly (karaf, deps, the app, config likely) and it will not require the daemon to be present (which avoids version issues ;))

That said it is an awesome move! +1

This comment has been minimized.

Copy link
@jbonofre

jbonofre Mar 22, 2019

Author Member

Thanks for the update, I wanted to provide something very simple. I fully agree about jib, I will add a profile to illustrate this.

Thanks !!!!

@jbonofre jbonofre force-pushed the jbonofre:CLOUD branch from 139a1f6 to 5b2a328 Mar 23, 2019

@jbonofre

This comment has been minimized.

Copy link
Member Author

jbonofre commented Apr 17, 2019

Split into two PRs.

@jbonofre jbonofre closed this Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.