Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4478 Use secure AES/CFB/PKCS5Padding instead of insecure AES/ECB/PKCS5Padding #1250

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

shaofengshi
Copy link
Contributor

Proposed changes

see https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-4477?filter=allissues
and https://issues.apache.org/jira/projects/KYLIN/issues/KYLIN-4478?filter=allissues

Types of changes

What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on Kylin's jira, and have described the bug/feature there in detail
  • Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I will prepare another pr against the document branch
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

mahirkabir and others added 3 commits June 9, 2020 11:06
Signed-off-by: shaofengshi <shaofengshi@apache.org>
…insecure AES/ECB/PKCS5Padding

Signed-off-by: shaofengshi <shaofengshi@apache.org>
@codecov-commenter
Copy link

Codecov Report

Merging #1250 into master will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1250   +/-   ##
=========================================
  Coverage     25.71%   25.72%           
- Complexity     6625     6629    +4     
=========================================
  Files          1484     1484           
  Lines         91185    91186    +1     
  Branches      12726    12726           
=========================================
+ Hits          23450    23459    +9     
+ Misses        65432    65427    -5     
+ Partials       2303     2300    -3     
Impacted Files Coverage Δ Complexity Δ
...ine/mr/common/DefaultSslProtocolSocketFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/org/apache/kylin/common/util/EncryptUtil.java 55.17% <100.00%> (+23.02%) 6.00 <1.00> (+2.00)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0.00%> (-2.33%) 12.00% <0.00%> (ø%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.30% <0.00%> (-0.92%) 7.00% <0.00%> (ø%)
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0.00%> (+2.27%) 8.00% <0.00%> (+1.00%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0.00%> (+2.30%) 0.00% <0.00%> (ø%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 40.47% <0.00%> (+4.76%) 6.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc4aae8...0d9dde2. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5988

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.005%) to 28.252%

Changes Missing Coverage Covered Lines Changed/Added Lines %
engine-mr/src/main/java/org/apache/kylin/engine/mr/common/DefaultSslProtocolSocketFactory.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 5987: 0.005%
Covered Lines: 25762
Relevant Lines: 91186

💛 - Coveralls

@shaofengshi shaofengshi merged commit 0884c27 into apache:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants