Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3597 Improve code smell #288

Merged
merged 1 commit into from Oct 14, 2018

Conversation

Projects
None yet
5 participants
@caolijun1166
Copy link
Contributor

caolijun1166 commented Oct 13, 2018

KYLIN-3597 Improve code smell

@asfgit

This comment has been minimized.

Copy link

asfgit commented Oct 13, 2018

Can one of the admins verify this patch?

@caolijun1166 caolijun1166 force-pushed the caolijun1166:KYLIN-3597 branch from de133c3 to 67ed23e Oct 13, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 13, 2018

Pull Request Test Coverage Report for Build 3765

  • 3 of 92 (3.26%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 23.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java 0 1 0.0%
core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java 1 19 5.26%
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 2 72 2.78%
Files with Coverage Reduction New Missed Lines %
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 2 15.82%
Totals Coverage Status
Change from base Build 3758: 0.006%
Covered Lines: 16312
Relevant Lines: 69966

💛 - Coveralls
@@ -100,6 +100,9 @@ public static CubeManager getInstance(KylinConfig config) {
return config.getManager(CubeManager.class);
}

private static final String FOR_CUBE = "For cube ";
private static final String SEGMENT = ", segment ";

This comment has been minimized.

Copy link
@shaofengshi

shaofengshi Oct 13, 2018

Contributor

I don't think this worth to declare.

@caolijun1166 caolijun1166 force-pushed the caolijun1166:KYLIN-3597 branch from 67ed23e to ec3c510 Oct 14, 2018

@caolijun1166 caolijun1166 force-pushed the caolijun1166:KYLIN-3597 branch from ec3c510 to 45af68f Oct 14, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 14, 2018

Codecov Report

Merging #288 into master will increase coverage by 0.01%.
The diff coverage is 3.26%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #288      +/-   ##
===========================================
+ Coverage     21.29%   21.3%   +0.01%     
  Complexity     4442    4442              
===========================================
  Files          1087    1087              
  Lines         69953   69966      +13     
  Branches      10107   10107              
===========================================
+ Hits          14894   14907      +13     
- Misses        53650   53656       +6     
+ Partials       1409    1403       -6
Impacted Files Coverage Δ Complexity Δ
...age/hbase/lookup/LookupTableHFilesBulkLoadJob.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/kylin/common/KylinConfigBase.java 14.68% <2.77%> (ø) 36 <2> (ø) ⬇️
...c/main/java/org/apache/kylin/cube/CubeManager.java 39.71% <5.26%> (-0.96%) 42 <0> (ø)
...lin/dict/lookup/cache/RocksDBLookupTableCache.java 76.68% <0%> (+0.51%) 27% <0%> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0%> (+3.64%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdafecc...45af68f. Read the comment docs.

@shaofengshi shaofengshi merged commit ae9c24a into apache:master Oct 14, 2018

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@caolijun1166 caolijun1166 deleted the caolijun1166:KYLIN-3597 branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.