From 3d2c9f1aeb8aa688e9625fa53a4d4fdf049b7617 Mon Sep 17 00:00:00 2001
From: Weiqing Xu <weiqxu@apache.org>
Date: Mon, 8 Apr 2019 23:23:03 +0800
Subject: [PATCH] KYLIN-3608 Move dependency versions to top level pom
 properties

---
 core-common/pom.xml        |  2 +-
 datasource-sdk/pom.xml     |  2 +-
 engine-spark/pom.xml       |  2 +-
 pom.xml                    | 64 +++++++++++++++++++++++++-------------
 stream-coordinator/pom.xml |  4 +--
 stream-core/pom.xml        |  4 +--
 stream-receiver/pom.xml    | 10 +++---
 7 files changed, 55 insertions(+), 33 deletions(-)

diff --git a/core-common/pom.xml b/core-common/pom.xml
index e77657a2c9b..cc0d55de0bd 100644
--- a/core-common/pom.xml
+++ b/core-common/pom.xml
@@ -89,7 +89,7 @@
         <dependency>
             <groupId>commons-dbcp</groupId>
             <artifactId>commons-dbcp</artifactId>
-            <version>1.4</version>
+            <version>${commons-dbcp.version}</version>
         </dependency>
         <dependency>
             <groupId>mysql</groupId>
diff --git a/datasource-sdk/pom.xml b/datasource-sdk/pom.xml
index 3c41b83d720..cd5c5510123 100644
--- a/datasource-sdk/pom.xml
+++ b/datasource-sdk/pom.xml
@@ -51,7 +51,7 @@
         <!--<dependency>-->
         <!--<groupId>com.microsoft.sqlserver</groupId>-->
         <!--<artifactId>mssql-jdbc</artifactId>-->
-        <!--<version>6.2.2.jre8</version>-->
+        <!--<version>${mssql-jdbc.version}</version>-->
         <!--<scope>provided</scope>-->
         <!--</dependency>-->
 
diff --git a/engine-spark/pom.xml b/engine-spark/pom.xml
index 40c879604b7..5c88001379f 100644
--- a/engine-spark/pom.xml
+++ b/engine-spark/pom.xml
@@ -97,7 +97,7 @@
         <dependency>
             <groupId>org.reflections</groupId>
             <artifactId>reflections</artifactId>
-            <version>0.9.10</version>
+            <version>${reflections.version}</version>
             <scope>test</scope>
         </dependency>
 
diff --git a/pom.xml b/pom.xml
index a1d68e1ebd2..1135d6f2cd1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -44,8 +44,26 @@
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
     <maven-model.version>3.3.9</maven-model.version>
+    <maven-compiler.version>3.5.1</maven-compiler.version>
+    <maven-site.version>3.5.1</maven-site.version>
+    <maven-install.version>2.5.2</maven-install.version>
+    <maven-resources.version>3.0.1</maven-resources.version>
+    <maven-shade.version>3.0.0</maven-shade.version>
+    <maven-jar.version>3.0.2</maven-jar.version>
+    <maven-war.version>2.6</maven-war.version>
+    <maven-release.version>2.5.3</maven-release.version>
+    <maven-checkstyle.version>2.17</maven-checkstyle.version>
+    <checksum-maven.version>1.3</checksum-maven.version>
+    <exec-maven.version>1.6.0</exec-maven.version>
+    <maven-dependency.version>2.10</maven-dependency.version>
+    <maven-project-info-reports.version>2.9</maven-project-info-reports.version>
+    <eclipse.lifecycle-mapping.version>1.0.1</eclipse.lifecycle-mapping.version>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+    <puppycrawl.version>8.6</puppycrawl.version>
+    <spotbugs.version>3.1.1</spotbugs.version>
+
+    <kylin.version>3.0.0</kylin.version>
 
     <!-- Hadoop versions -->
     <hadoop2.version>2.7.1</hadoop2.version>
@@ -71,7 +89,7 @@
     <!-- Scala versions -->
     <scala.version>2.11.0</scala.version>
 
-    <!-- <reflections.version>0.9.10</reflections.version> -->
+    <reflections.version>0.9.10</reflections.version>
 
     <!-- Calcite Version, the kylin fork is: https://github.com/Kyligence/calcite -->
     <calcite.version>1.16.0-kylin-r2</calcite.version>
@@ -103,13 +121,15 @@
     <jetty.version>9.3.22.v20171030</jetty.version>
     <jamm.version>0.3.1</jamm.version>
     <mockito.version>2.7.14</mockito.version>
+    <mockito-all.version>1.9.5</mockito-all.version>
     <powermock.version>1.7.0</powermock.version>
 
     <!-- Commons -->
     <commons-lang3.version>3.4</commons-lang3.version>
     <commons-email.version>1.5</commons-email.version>
     <commons-validator.version>1.4.0</commons-validator.version>
-    <commons-compress>1.18</commons-compress>
+    <commons-compress.version>1.18</commons-compress.version>
+    <commons-dbcp.version>1.4</commons-dbcp.version>
 
     <!-- Utility -->
     <log4j.version>1.2.17</log4j.version>
@@ -127,6 +147,8 @@
     <t-digest.version>3.1</t-digest.version>
     <freemarker.version>2.3.23</freemarker.version>
     <rocksdb.version>5.9.2</rocksdb.version>
+    <lz4.version>1.3.0</lz4.version>
+    <mssql-jdbc.version>6.2.2.jre8</mssql-jdbc.version>
     <!--metric-->
     <dropwizard.version>3.1.2</dropwizard.version>
     <!-- REST Service, ref https://github.com/spring-projects/spring-boot/blob/v1.3.8.RELEASE/spring-boot-dependencies/pom.xml -->
@@ -747,7 +769,7 @@
       <dependency>
         <groupId>org.apache.commons</groupId>
         <artifactId>commons-compress</artifactId>
-        <version>${commons-compress}</version>
+        <version>${commons-compress.version}</version>
       </dependency>
       <dependency>
         <groupId>org.freemarker</groupId>
@@ -1091,7 +1113,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
-          <version>3.5.1</version>
+          <version>${maven-compiler.version}</version>
           <configuration>
             <source>${javaVersion}</source>
             <target>${javaVersion}</target>
@@ -1100,17 +1122,17 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-site-plugin</artifactId>
-          <version>3.5.1</version>
+          <version>${maven-site.version}</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-install-plugin</artifactId>
-          <version>2.5.2</version>
+          <version>${maven-install.version}</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-resources-plugin</artifactId>
-          <version>3.0.1</version>
+          <version>${maven-resources.version}</version>
           <configuration>
             <encoding>UTF-8</encoding>
           </configuration>
@@ -1118,7 +1140,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-jar-plugin</artifactId>
-          <version>3.0.2</version>
+          <version>${maven-jar.version}</version>
           <executions>
             <execution>
               <goals>
@@ -1130,12 +1152,12 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-shade-plugin</artifactId>
-          <version>3.0.0</version>
+          <version>${maven-shade.version}</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-war-plugin</artifactId>
-          <version>2.6</version>
+          <version>${maven-war.version}</version>
           <configuration>
             <packagingExcludes>
               WEB-INF/lib/servlet-api-*.jar,
@@ -1150,7 +1172,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-source-plugin</artifactId>
-          <version>3.0.1</version>
+          <version>${maven-resources.version}</version>
           <executions>
             <execution>
               <id>attach-sources</id>
@@ -1167,7 +1189,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-release-plugin</artifactId>
-          <version>2.5.3</version>
+          <version>${maven-release.version}</version>
         </plugin>
         <plugin>
           <groupId>org.jacoco</groupId>
@@ -1177,12 +1199,12 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.17</version>
+          <version>${maven-checkstyle.version}</version>
           <dependencies>
             <dependency>
               <groupId>com.puppycrawl.tools</groupId>
               <artifactId>checkstyle</artifactId>
-              <version>8.6</version>
+              <version>${puppycrawl.version}</version>
             </dependency>
           </dependencies>
           <executions>
@@ -1205,7 +1227,7 @@
         <plugin>
           <groupId>com.github.spotbugs</groupId>
           <artifactId>spotbugs-maven-plugin</artifactId>
-          <version>3.1.1</version>
+          <version>${spotbugs.version}</version>
           <configuration>
             <xmlOutput>true</xmlOutput>
             <effort>Max</effort>
@@ -1216,12 +1238,12 @@
         <plugin>
           <groupId>net.ju-n.maven.plugins</groupId>
           <artifactId>checksum-maven-plugin</artifactId>
-          <version>1.3</version>
+          <version>${checksum-maven.version}</version>
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>exec-maven-plugin</artifactId>
-          <version>1.6.0</version>
+          <version>${exec-maven.version}</version>
         </plugin>
         <plugin>
           <groupId>org.springframework.boot</groupId>
@@ -1231,7 +1253,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-dependency-plugin</artifactId>
-          <version>2.10</version>
+          <version>${maven-dependency.version}</version>
         </plugin>
 
         <plugin>
@@ -1320,7 +1342,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-project-info-reports-plugin</artifactId>
-        <version>2.9</version>
+        <version>${maven-project-info-reports.version}</version>
         <reportSets>
           <reportSet>
             <reports>
@@ -1347,7 +1369,7 @@
       <plugin>
         <groupId>com.github.spotbugs</groupId>
         <artifactId>spotbugs-maven-plugin</artifactId>
-        <version>3.1.1</version>
+        <version>${spotbugs.version}</version>
       </plugin>
     </plugins>
   </reporting>
@@ -1824,7 +1846,7 @@
             <plugin>
               <groupId>org.eclipse.m2e</groupId>
               <artifactId>lifecycle-mapping</artifactId>
-              <version>1.0.0</version>
+              <version>${eclipse.lifecycle-mapping.version}</version>
               <configuration>
                 <lifecycleMappingMetadata>
                   <pluginExecutions>
diff --git a/stream-coordinator/pom.xml b/stream-coordinator/pom.xml
index 292509e757e..9911ec5f417 100644
--- a/stream-coordinator/pom.xml
+++ b/stream-coordinator/pom.xml
@@ -82,7 +82,7 @@
         <dependency>
             <groupId>org.apache.curator</groupId>
             <artifactId>curator-test</artifactId>
-            <version>2.12.0</version>
+            <version>${curator.version}</version>
             <scope>test</scope>
         </dependency>
 
@@ -96,7 +96,7 @@
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-all</artifactId>
-            <version>1.9.5</version>
+            <version>${mockito-all.version}</version>
             <scope>test</scope>
         </dependency>
 
diff --git a/stream-core/pom.xml b/stream-core/pom.xml
index 0be78b23b2d..e6fa05c7e3c 100644
--- a/stream-core/pom.xml
+++ b/stream-core/pom.xml
@@ -66,7 +66,7 @@
         <dependency>
             <groupId>org.rocksdb</groupId>
             <artifactId>rocksdbjni</artifactId>
-            <version>5.0.1</version>
+            <version>${rocksdb.version}</version>
         </dependency>
         <dependency>
             <groupId>io.dropwizard.metrics</groupId>
@@ -76,7 +76,7 @@
         <dependency>
             <groupId>net.jpountz.lz4</groupId>
             <artifactId>lz4</artifactId>
-            <version>1.3.0</version>
+            <version>${lz4.version}</version>
         </dependency>
 
         <!-- Env & Test -->
diff --git a/stream-receiver/pom.xml b/stream-receiver/pom.xml
index 1b232259e09..bdcd6dab323 100644
--- a/stream-receiver/pom.xml
+++ b/stream-receiver/pom.xml
@@ -133,7 +133,7 @@
         <dependency>
             <groupId>cglib</groupId>
             <artifactId>cglib</artifactId>
-            <version>2.2.2</version>
+            <version>${cglib.version}</version>
         </dependency>
 
         <!-- spring aop -->
@@ -205,17 +205,17 @@
         <!--<dependency>-->
         <!--<groupId>org.apache.tomcat.embed</groupId>-->
         <!--<artifactId>tomcat-embed-core</artifactId>-->
-        <!--<version>7.0.52</version>-->
+        <!--<version>${tomcat.version}</version>-->
         <!--</dependency>-->
         <!--<dependency>-->
         <!--<groupId>org.apache.tomcat.embed</groupId>-->
         <!--<artifactId>tomcat-embed-logging-juli</artifactId>-->
-        <!--<version>7.0.52</version>-->
+        <!--<version>${tomcat.version}</version>-->
         <!--</dependency>-->
         <!--<dependency>-->
         <!--<groupId>org.apache.tomcat.embed</groupId>-->
         <!--<artifactId>tomcat-embed-jasper</artifactId>-->
-        <!--<version>7.0.52</version>-->
+        <!--<version>${tomcat.version}</version>-->
         <!--</dependency>-->
         <dependency>
             <groupId>org.eclipse.jetty</groupId>
@@ -243,7 +243,7 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>
-                <version>2.2</version>
+                <version>${maven-shade.version}</version>
                 <executions>
                     <execution>
                         <phase>package</phase>