Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RT OLAP building job on "Save Cube Dictionaries" step concurrency error #869

Closed
wants to merge 2 commits into from

Conversation

@wangxiaojing123
Copy link
Contributor

wangxiaojing123 commented Sep 30, 2019

@asf-ci

This comment has been minimized.

Copy link

asf-ci commented Sep 30, 2019

Can one of the admins verify this patch?

…urrency error , fix unit test error
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #869 into master will decrease coverage by 0.07%.
The diff coverage is 0.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #869      +/-   ##
===========================================
- Coverage     25.47%   25.4%   -0.08%     
+ Complexity     6109    6106       -3     
===========================================
  Files          1410    1411       +1     
  Lines         84919   85120     +201     
  Branches      11897   11942      +45     
===========================================
- Hits          21633   21621      -12     
- Misses        61204   61418     +214     
+ Partials       2082    2081       -1
Impacted Files Coverage Δ Complexity Δ
...apache/kylin/engine/mr/streaming/SaveDictStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...che/kylin/engine/mr/StreamingCubingJobBuilder.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/kylin/engine/mr/common/CubeJobLockUtil.java 0% <0%> (ø) 0 <0> (?)
...che/kylin/job/lock/zookeeper/ZookeeperJobLock.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/job/lock/zookeeper/ZookeeperDistributedLock.java 49.35% <0%> (-5.33%) 18 <0> (ø)
...java/org/apache/kylin/rest/service/JobService.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...he/kylin/engine/mr/common/MapReduceExecutable.java 13.33% <0.81%> (-9.4%) 6 <1> (ø)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0%> (-3.41%) 8% <0%> (ø)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e64c23...49bd4e9. Read the comment docs.

@wangxiaojing123

This comment has been minimized.

Copy link
Contributor Author

wangxiaojing123 commented Dec 3, 2019

add a new pr #973

@nichunen

This comment has been minimized.

Copy link
Contributor

nichunen commented Dec 4, 2019

Updated with PR #973
Close this one

@nichunen nichunen closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.