Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4244: add com.tdunning shade in tool assembly #924

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@zhoukangcn
Copy link
Contributor

zhoukangcn commented Nov 7, 2019

@asf-ci

This comment has been minimized.

Copy link

asf-ci commented Nov 7, 2019

Can one of the admins verify this patch?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 7, 2019

Pull Request Test Coverage Report for Build 5193

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 27.903%

Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java 1 47.62%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals Coverage Status
Change from base Build 5189: -0.005%
Covered Lines: 23726
Relevant Lines: 85030

💛 - Coveralls
Copy link
Contributor

nichunen left a comment

LGTM

@nichunen nichunen merged commit 3445e93 into apache:master Nov 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zhoukangcn zhoukangcn deleted the zhoukangcn:KYLIN-4244 branch Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.