From d3e25f0869665b81d6e08e3f169ef39e7cf42b93 Mon Sep 17 00:00:00 2001 From: jiaoqingbo <1178404354@qq.com> Date: Sat, 2 Apr 2022 21:10:05 +0800 Subject: [PATCH] [KYUUBI #2266] The default value of frontend.connection.url.use.hostname should be set to true to be consistent with previous versions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### _Why are the changes needed?_ fix #2266 in 1.5.0 version，the seriviceUri consists of ip:port e3c7a03dbcbeeaedce52139755fe227 in 1.4.1 version ，the seriviceUri consists of hostname:port 88cf334a0a425227ed6be7637fc10bd using following command to connect would failed ./bin/beeline -u 'jdbc:hive2://ocdp63.asiainfo.com:2008,ocdp172.asiainfo.com:2008,ocdnfo.com:2008/default;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=kyuubi;principal=spark/_HOSTocdp;' ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2269 from jiaoqingbo/2266. Closes #2266 b77b19d8 [jiaoqingbo] modify doc e87d9670 [jiaoqingbo] [KYUUBI #2266] The default value of frontend.connection.url.use.hostname should be set to true to be consistent with previous versions 25063a34 [jiaoqingbo] Merge branch 'master' of https://github.com/jiaoqingbo/incubator-kyuubi 0ad3b764 [jiaoqingbo] Merge branch 'master' of https://github.com/jiaoqingbo/incubator-kyuubi f9d68c7f [jiaoqingbo] [KYUUBI #2244] load-kyuubi-env.sh should print SPARK_ENGINE_HOME for consistency Authored-by: jiaoqingbo <1178404354@qq.com> Signed-off-by: Kent Yao (cherry picked from commit c1a68a7cf3b2c6d83a302f3b2ffaa639cef1932d) Signed-off-by: Kent Yao --- docs/deployment/settings.md | 4 ++-- .../src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/deployment/settings.md b/docs/deployment/settings.md index d84577d2a84..572491c15fb 100644 --- a/docs/deployment/settings.md +++ b/docs/deployment/settings.md @@ -178,7 +178,7 @@ Key | Default | Meaning | Type | Since Key | Default | Meaning | Type | Since --- | --- | --- | --- | --- -kyuubi.engine.connection.url.use.hostname|
false
|
(deprecated) When true, engine register with hostname to zookeeper. When spark run on k8s with cluster mode, set to false to ensure that server can connect to engine
|
boolean
|
1.3.0
+kyuubi.engine.connection.url.use.hostname|
true
|
(deprecated) When true, engine register with hostname to zookeeper. When spark run on k8s with cluster mode, set to false to ensure that server can connect to engine
|
boolean
|
1.3.0
kyuubi.engine.deregister.exception.classes|
|
A comma separated list of exception classes. If there is any exception thrown, whose class matches the specified classes, the engine would deregister itself.
|
seq
|
1.2.0
kyuubi.engine.deregister.exception.messages|
|
A comma separated list of exception messages. If there is any exception thrown, whose message or stacktrace matches the specified message list, the engine would deregister itself.
|
seq
|
1.2.0
kyuubi.engine.deregister.exception.ttl|
PT30M
|
Time to live(TTL) for exceptions pattern specified in kyuubi.engine.deregister.exception.classes and kyuubi.engine.deregister.exception.messages to deregister engines. Once the total error count hits the kyuubi.engine.deregister.job.max.failures within the TTL, an engine will deregister itself and wait for self-terminated. Otherwise, we suppose that the engine has recovered from temporary failures.
|
duration
|
1.2.0
@@ -215,7 +215,7 @@ Key | Default | Meaning | Type | Since kyuubi.frontend.backoff.slot.length|
PT0.1S
|
(deprecated) Time to back off during login to the thrift frontend service.
|
duration
|
1.0.0
kyuubi.frontend.bind.host|
<undefined>
|
(deprecated) Hostname or IP of the machine on which to run the thrift frontend service via binary protocol.
|
string
|
1.0.0
kyuubi.frontend.bind.port|
10009
|
(deprecated) Port of the machine on which to run the thrift frontend service via binary protocol.
|
int
|
1.0.0
-kyuubi.frontend.connection.url.use.hostname|
false
|
When true, frontend services prefer hostname, otherwise, ip address
|
boolean
|
1.5.0
+kyuubi.frontend.connection.url.use.hostname|
true
|
When true, frontend services prefer hostname, otherwise, ip address
|
boolean
|
1.5.0
kyuubi.frontend.login.timeout|
PT20S
|
(deprecated) Timeout for Thrift clients during login to the thrift frontend service.
|
duration
|
1.0.0
kyuubi.frontend.max.message.size|
104857600
|
(deprecated) Maximum message size in bytes a Kyuubi server will accept.
|
int
|
1.0.0
kyuubi.frontend.max.worker.threads|
999
|
(deprecated) Maximum number of threads in the of frontend worker thread pool for the thrift frontend service
|
int
|
1.0.0
diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala index 73ce96326a7..49a190dc36d 100644 --- a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala +++ b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala @@ -889,7 +889,7 @@ object KyuubiConf { " with cluster mode, set to false to ensure that server can connect to engine") .version("1.3.0") .booleanConf - .createWithDefault(false) + .createWithDefault(true) val FRONTEND_CONNECTION_URL_USE_HOSTNAME: ConfigEntry[Boolean] = buildConf("frontend.connection.url.use.hostname")