From eaee5e845c8f72598f4520595a4e5575426f3f35 Mon Sep 17 00:00:00 2001 From: Bowen Liang Date: Mon, 6 Nov 2023 11:12:28 +0800 Subject: [PATCH] [KYUUBI #5626] [UI] Fix sytle linting violation in web ui MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### _Why are the changes needed?_ - To fix the style violation in web UI linting `cd ./kyuubi-server/web-ui && pnpm run lint` ``` > kyuubi-ui1.9.0-SNAPSHOT lint /Users/bw/dev/kyuubi/kyuubi-server/web-ui > eslint --ext .ts,vue --ignore-path .gitignore . /Users/bw/dev/kyuubi/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts 37:25 error Delete `⏎····` prettier/prettier ✖ 1 problem (1 error, 0 warnings) 1 error and 0 warnings potentially fixable with the `--fix` option.  ELIFECYCLE  Command failed with exit code 1. ``` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ No. Closes #5626 from bowenliang123/webui-lint-fix. Closes #5626 b1c7d7bc7 [Bowen Liang] web ui lint fix Authored-by: Bowen Liang Signed-off-by: Cheng Pan --- kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts b/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts index 95a4fe0eb14..b7999ad173d 100644 --- a/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts +++ b/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts @@ -34,6 +34,5 @@ test('mount component', () => { plugins: [mockRouter, getStore()] } }) - expect(wrapper.text()) - .toContain(import.meta.env.VITE_APP_VERSION) + expect(wrapper.text()).toContain(import.meta.env.VITE_APP_VERSION) })