[KYUUBI #7248] JDBC engine should cancel the statement when receive cancel operation #7249
+108
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7249 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 696
Lines 43530 43530
Branches 5883 5883
======================================
Misses 43530 43530 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruanwenjun
force-pushed
the
dev_wenjun_fix7248
branch
from
ded4d77 to
2e863b9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7249 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 696 696
Lines 43530 43530
Branches 5883 5883
======================================
Misses 43530 43530 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ruanwenjun
force-pushed
the
dev_wenjun_fix7248
branch
2 times, most recently
from
ef8038f to
c154799
Compare
…receive cancel operation
ruanwenjun
force-pushed
the
dev_wenjun_fix7248
branch
from
c154799 to
f97ceae
Compare
Member
Author
|
@pan3793 PTAL |
pan3793
reviewed
Nov 20, 2025
...dbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/OperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
...dbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/OperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/StarRocksOperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
...c/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/StarRocksOperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Nov 20, 2025
...bi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/ExecuteStatement.scala
Show resolved
Hide resolved
pan3793
reviewed
Nov 20, 2025
...dbc-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/mysql/OperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_fix7248
branch
from
d228ffa to
f2f9eed
Compare
pan3793
reviewed
Nov 20, 2025
kyuubi-common/src/test/scala/org/apache/kyuubi/operation/HiveJDBCTestHelper.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Nov 20, 2025
...bi-jdbc-engine/src/main/scala/org/apache/kyuubi/engine/jdbc/operation/ExecuteStatement.scala
Outdated
Show resolved
Hide resolved
ruanwenjun
commented
Nov 20, 2025
...c-engine/src/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/WithStarRocksContainer.scala
Show resolved
Hide resolved
ruanwenjun
force-pushed
the
dev_wenjun_fix7248
branch
from
60519d1 to
734e6c4
Compare
pan3793
reviewed
Nov 20, 2025
...c/test/scala/org/apache/kyuubi/engine/jdbc/starrocks/StarRocksOperationWithEngineSuite.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Nov 20, 2025
pan3793
changed the title
pan3793
added a commit
that referenced
this pull request
Nov 20, 2025
…ancel operation ### Why are the changes needed? close #7248 - Cancel the jdbc statement when receive a kyuubi cancel operation ### How was this patch tested? Test by new ut case ### Was this patch authored or co-authored using generative AI tooling? No Closes #7249 from ruanwenjun/dev_wenjun_fix7248. Closes #7248 fa847ec [Cheng Pan] Apply suggestion from @pan3793 734e6c4 [ruanwenjun] polish code 76112f3 [ruanwenjun] change starrocks image to 3.3.13 f2f9eed [ruanwenjun] add status assertion in new ut case 33e0f0d [ruanwenjun] add assert in ut c22feb5 [ruanwenjun] move todo to ExecuteStatement a132f36 [ruanwenjun] improve ut f97ceae [ruanwenjun] [KYUUBI #7248] Ensure jdbc engine statements are canceled when receive cancel operation Lead-authored-by: ruanwenjun <wenjun@apache.org> Co-authored-by: Cheng Pan <pan3793@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit f2539d2) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
|
JDBC engine tests have passed, merged to master/1.10, thanks @ruanwenjun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #7248
How was this patch tested?
Test by new ut case
Was this patch authored or co-authored using generative AI tooling?
No