Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Limit number of retries in Azure ARM destroy_node. #1134
Limit number of retries in Azure ARM destroy_node.
Azure ARM has several retry loops related to deleting the NIC and VHD as part of node cleanup. This bounds those loops so they don't retry forever.
Checklist (tick everything that applies)
pquentin left a comment
Thanks, the change make sense! There's a small docstring change. Also, the lint does not pass.
A possible future improvement is to use libcloud.utils.misc.retry which would reduce verbosity here and allow to add exponential back-off.
@@ Coverage Diff @@ ## trunk #1134 +/- ## ========================================== + Coverage 85.49% 85.49% +<.01% ========================================== Files 348 348 Lines 66499 66527 +28 Branches 5921 5922 +1 ========================================== + Hits 56852 56876 +24 - Misses 7239 7243 +4 Partials 2408 2408